London | 25-ITP-September | Alexandru Pocovnicu | Coursework/sprint 3 | 2 practice tdd #776

alexandru-pocovnicu · 2025-10-16T15:07:06Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this PR I have implemented test driven development by first writing the test cases and then implementing the functions to make those tests pass.

…ling for negative counts

github-actions · 2025-10-16T15:07:30Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-16T15:07:30Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-16T15:07:30Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-16T15:07:31Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-16T15:07:32Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-16T15:07:34Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T21:21:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T21:21:26Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova

Hi @alexandru-pocovnicu! You did a really good job with writing unit tests but I think they could be more comprehensive. You can see the value of a good test suite from the bug that was missed in the getOrdinalNumber function simply because the tests only covered one scenario for that particular condition.

jennethydyrova · 2025-10-23T21:24:57Z

Sprint-3/2-practice-tdd/count.js

+  let char=0;
+  for(let i=0;i<stringOfCharacters.length;i++){
+    if(stringOfCharacters[i]===findCharacter){
+      char++;
+    }
+  }
+  return char


I am being a bit nit picky here but it's a bit hard to read your function because of the odd formatting of the code (no spaces between words). If you use Visual Studio Code, I would suggest installing Prettier to auto-format your code on save. This will make it faster to write code as you won't need to worry about formatting.

https://www.youtube.com/watch?v=drtxWx1XojI

Thank you, already got it , looked around to see if I need to enable something especially for that but couldn't find anything, could it be something else is overriding it's default settings ?

You may want to check the How to set up and change Prettier settings section of the video I attached

jennethydyrova · 2025-10-23T21:32:18Z

Sprint-3/2-practice-tdd/count.test.js

 // And a character char that does not exist within the case-sensitive str,
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+test("should return 0 if the character doesn't appear in the string",()=>{


This test case is good but can you think of other test cases? For example, what happens in the following cases:

str="a", char="aa"

str="", char="a"

str="a b c d", char=" "

and etc. I think there are a few test cases to consider, as str and char can vary in length, type and content. This will show you if you have protected against various edge cases your function.

I've done it but with the help of the copilot , I wouldn't've been able to do it by myself

I would suggest discussing this with your classmates as it's quite important to understand why we write this kind of test cases and how we write them.

Sprint-3/2-practice-tdd/get-ordinal-number.js

jennethydyrova · 2025-10-23T21:36:16Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+    return `${num}st`;
+  } else if (lastDigit === 2) {
+    return `${num}nd`;
+  } else if (num === 3) {


Are you sure this is the right condition? Looks like a bug.

jennethydyrova · 2025-10-23T21:43:44Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

  expect(getOrdinalNumber(1)).toEqual("1st");
 });
+
+test("should return '121st' for 121", () =>{


These test cases are good but I think there are more edge cases that you could cover to make sure your function behaves in a way you designed. For example, what happens when you pass 0 or 1.5?

Also, I think you could have more comprehensive test cases for numbers. With the current bug you have 33 will not become 33rd and you could catch this bug if you included more tests for each type of ordinal number. If I were you, I would be adding test cases for the 1 digit number, 2 digit number and 3 digits number for each ordinal number type.

not sure about the negative numbers, left the test in there anyway

jennethydyrova · 2025-10-23T21:48:12Z

Sprint-3/2-practice-tdd/repeat.test.js

 // When the repeat function is called with these inputs,
 // Then it should return the original str without repetition, ensuring that a count of 1 results in no repetition.

+test("should not repeat the string", ()=>{


Same as above, these test cases are good but they are a bit slim. You could add couple of more tests to test different variations of count and try to break your function by adding some tests for edge cases, like in the case you pass str="".

I added a few more tests for str as for count the requirement says it's a positive integer , no point to test for NaN etc, I also commented out the test for count = 0 , 0 not being a positive integer.

I think 0 is a nice corner case you should have in your test case.

Regarding the requirement, yes, there is a test for positive values, but do you see why we actually need that test case? It's not just because requirements say count must be positive. It's because JavaScript's .repeat() throws a RangeError for negative numbers, and your if(count<0) check is safeguarding against that. That's to say, you can add guardrails beyond what requirements specify based on how your function actually works. For example, .repeat() also throws errors for Infinity and behaves weirdly for undefined. Testing these cases helps you figure out what other safeguards you might want to add to make your function more robust.

You can think of it another way: you can't repeat something negative times, and that's why you have that unit test. Following the same logic, you also can't repeat something undefined times, right? So whether you're thinking about the function logically or from a technical perspective, there's always a set of inputs it shouldn't work with. Writing test cases for these different scenarios helps you catch those edge cases.

github-actions · 2025-10-23T21:53:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T21:53:22Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

…eration logic

… cases and various scenarios

…gic for ordinal suffixes

…ional valid inputs

Sprint-3/2-practice-tdd/count.js

Sprint-3/2-practice-tdd/count.test.js

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

alexandru-pocovnicu · 2025-10-26T20:19:55Z

Thank you @jennethydyrova for your time and help

github-actions · 2025-10-26T20:20:34Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T20:20:35Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T20:25:56Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T20:26:02Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

…e error messages

github-actions · 2025-10-27T11:21:48Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-27T11:21:49Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

… count

jennethydyrova · 2025-10-27T13:15:12Z

Looks good to me, great job!

github-actions · 2025-10-27T13:15:45Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-27T13:15:48Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework/sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova · 2025-10-28T10:45:17Z

@alexandru-pocovnicu I set the label to complete but just noticed that the check is failing, can you please fix it?

alexandru-pocovnicu added 7 commits October 16, 2025 09:34

Add test case for character not found in string

7b93eed

Implement character counting logic in countChar function

86a4f93

Added tests for repeat function handling various counts

7429d54

Implement repeat function to handle string repetition with error hand…

a59de40

…ling for negative counts

added tests for additional getordinalnumber function

9af1dec

added code to the getordinalfunction to cover all possibilities

de7beb8

added test to check for negative numbers

dd1f125

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 16, 2025

alexandru-pocovnicu mentioned this pull request Oct 23, 2025

ITP-2025-September | Structuring and testing data | Alexandru Pocovnicu. alexandru-pocovnicu/My-Coursework-Planner#60

Closed

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2025

jennethydyrova reviewed Oct 23, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 23, 2025

alexandru-pocovnicu added 5 commits October 24, 2025 11:10

refactor countChar function for improved readability

a2ae864

fix countChar function to handle empty character cases and improve it…

cf3d5cd

…eration logic

add additional tests for countChar function to handle empty character…

7f9d151

… cases and various scenarios

fix getOrdinalNumber function to handle invalid inputs and improve lo…

253d984

…gic for ordinal suffixes

add tests for getOrdinalNumber function to handle NaN cases and addit…

0f7f656

…ional valid inputs

jennethydyrova reviewed Oct 26, 2025

View reviewed changes

alexandru-pocovnicu added 5 commits October 26, 2025 19:53

removed scratch work

5d5d095

updated the function to handle empty strings

6c0be54

updated test case description

1a64458

update test descriptions for clarity on invalid inputs

eee22d9

refactor getOrdinalNumber function to improve input validation structure

a4b2b74

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 26, 2025

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

alexandru-pocovnicu added 3 commits October 27, 2025 08:17

fix formatting in getOrdinalNumber function for consistency

90a7852

update tests for repeat function to handle undefined count and improv…

7198839

…e error messages

refactor repeat function to improve input validation and error handling

b91f950

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 27, 2025

alexandru-pocovnicu added 2 commits October 27, 2025 12:27

refactor repeat function to enhance input validation for string type

9c86871

update tests for repeat function to handle non-string input and array…

e28e199

… count

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025

alexandru-pocovnicu mentioned this pull request Oct 30, 2025

ITP-2025-September | Structuring and Testing Data | Alexandru Pocovnicu alexandru-pocovnicu/My-Coursework-Planner#62

Open

Uh oh!

London | 25-ITP-September | Alexandru Pocovnicu | Coursework/sprint 3 | 2 practice tdd #776

Are you sure you want to change the base?

London | 25-ITP-September | Alexandru Pocovnicu | Coursework/sprint 3 | 2 practice tdd #776

Uh oh!

Conversation

alexandru-pocovnicu commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandru-pocovnicu commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

jennethydyrova commented Oct 27, 2025

alexandru-pocovnicu commented Oct 16, 2025 •

edited

Loading