Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 3 | Coursework/sprint 3 practice tdd #758

Alaa-Tagi · 2025-10-12T21:41:50Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have created a PR with completed tasks as required.

Questions

No questions

jennethydyrova

Hi @Alaa-Tagi! Great job on translating instructions into functions. It was quite easy to read your PR, which is always a good thing for a reviewer!

A couple of things to note:

You should try to remove all your testing and scratch work when pushing a PR (mostly console logs in your case).
Test cases need to be more comprehensive. Think of it this way: when you write different test cases for your functions, you help yourself catch bugs early. For example, currently your getOrdinalNumber function will most likely return "trueth" for num=true, which I don't think is the expected behavior.

jennethydyrova · 2025-10-23T21:55:57Z

Sprint-3/2-practice-tdd/count.js

+console.log(countChar('hello', 'l'));
+console.log(countChar('hello', 'z')); 
+console.log(countChar('alaaaaa', 'a'));
+


Let's keep the PR clean and focused. Could you please remove all console logs from your PR?

jennethydyrova · 2025-10-23T22:04:52Z

Sprint-3/2-practice-tdd/count.test.js

 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+
+test("should return 0 for no occurrences", () => {


This test is good but it doesn't test different possible function inputs. What if the inputs' types are not strings, the char string is longer than the str string, or you have an empty string for either of the inputs, etc.? Testing different inputs will show whether your function accounts for different scenarios, which is what makes a function robust.

jennethydyrova · 2025-10-23T22:07:31Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

 function getOrdinalNumber(num) {
-  return "1st";
+    num = num.toString();
+    if (num.slice(-2) === '11' || num.slice(-2) === '12' || num.slice(-2) === '13') {


Is there way not to repeat num.slice(-1) and num.slice(-2)?

jennethydyrova · 2025-10-23T22:11:17Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

 test("should return '1st' for 1", () => {
  expect(getOrdinalNumber(1)).toEqual("1st");
 });
+


I like these test cases but again, what are other expected/unexpected inputs your function can receive and how will it behave? For example, what if num is undefined, a boolean, etc.? That's just two examples of num being not of a type you expect.

jennethydyrova · 2025-10-23T22:12:19Z

Sprint-3/2-practice-tdd/repeat.js

+   const str = arguments[0];
+  const count = arguments[1];


Are you sure this is the right way of getting values of function arguments?

jennethydyrova · 2025-10-23T22:18:10Z

Sprint-3/2-practice-tdd/repeat.test.js

 // When the repeat function is called with these inputs,
 // Then it should return the original str without repetition, ensuring that a count of 1 results in no repetition.

+test("should return the original string when count is 1", () => {


This test suit are more comprehensive but can you think of other test cases?

Hi @jennethydyrova i have fixed all the errors that you have mentioned to me.

Have you tried running the tests you wrote?

If you try to run your unit tests, you will see that some of them are failing both for this function and getOrdinalNumber. Can you try to fix tests/functions by reading output produced when you run tests?

Yes, I have and it passed all the tests.

The unit tests in your screenshots do not match those in the PR. Take a look at Sprint-3/2-practice-tdd/get-ordinal-number.test.js file, for example. Your last test in this PR is

test("should handle decimal numbers", () => { expect(getOrdinalNumber(21.5)).toEqual("21.5th"); });

and on the screenshot you sent the last test is

test("should return '33rd' for 33", () => { expect(getOrdinalNumber(33)).toEqual("33rd"); });

@jennethydyrova,
I have edited this code if you could check down

Please always double check if you pushed your local changes, deleted all scratch work (including console logs) and ran all unit tests before requesting another round of review. It will reduce time I spend on reviewing your code and you going back to the same PR over and over again. File changes tab is quite useful for checking if you code is up to standard.

I don't see any new changes. I assume you made some local changes but you haven't pushed them.

@jennethydyrova, I am sorry and I appreciate your time. But I am so confused too I make the changes, do push as usual and in here every thing appears.

Like this pic here it shows that the changes has been push and I do not see any unstage files.

Thanks for you patient with me

No worries. Okay, I can see these changes and I can see from the function implementation, that this particular unit test on the screenshot you sent will fail but you can understand this by just running unit tests. You have these changes locally, right? If you have same changes locally and you run unit tests, some of them will fail in Sprint-3/2-practice-tdd folder indicating that some more work needs to be done.

jennethydyrova · 2025-10-26T19:04:26Z

Sprint-3/2-practice-tdd/count.test.js

+// Scenario: char string longer than str string
+test("should return 0 when char is longer than the input string", () => {
+  const str = "a";
+  const char = "abc";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: Non-string inputs
+test("should return 0 when inputs are not strings", () => {
+  expect(countChar(12345, "1")).toEqual(0);
+  expect(countChar("12345", 1)).toEqual(0);
+  expect(countChar(null, "a")).toEqual(0);
+  expect(countChar("hello", undefined)).toEqual(0);
+});


This is fine but when you read this function's purpose, you might think that if char is longer than str, it should perhaps throw an error as there is no way to count char occurrence in this case. It's fine to leave Scenario: char string longer than str string test case as is but it's something to consider while designing your function.

Same for Scenario: Non-string inputs but this test case should definitely throw errors.

jennethydyrova · 2025-10-26T19:04:42Z

Sprint-3/2-practice-tdd/count.test.js

+});
+
+// Scenario: Case sensitivity
+test("should count only exact case matches", () => {


Very thoughtful test case!

jennethydyrova · 2025-10-26T19:05:42Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+console.log(getOrdinalNumber(1));
+console.log(getOrdinalNumber(2));
+console.log(getOrdinalNumber(3));
+console.log(getOrdinalNumber(4));
+console.log(getOrdinalNumber(11));
+console.log(getOrdinalNumber(22));
+console.log(getOrdinalNumber(33));


Please let's remove these and all other console logs. These should be for your usage only and they should be deleted before pushing changes.

okay, i did that. it was on my mind but i forgot to remove them before push it

jennethydyrova · 2025-10-26T19:13:38Z

Sprint-3/2-practice-tdd/repeat.test.js

+test("should handle undefined inputs gracefully", () => {
+  expect(() => repeat(undefined, 3)).toThrow();
+  expect(() => repeat("hello")).toThrow();
+  expect(() => repeat()).toThrow();
+});


This doesn't look correct to me. Your function doesn't throw any errors in the cases you wrote here.

i fixed the code

@jennethydyrova , Here the new code ( Editied )

Your tests are still failing. These are all tests in Sprint-3/2-practice-tdd folder . Also, you have some error in one of the files.

Alaa-Tagi · 2025-10-27T00:23:39Z

i have editing both get ordinal and repeat code . also i have tried both tests with different laptop it showed failed but in my laptop showed passed i dont know why but i will figure it out later. so, i editing the two codes and tried to run them on another laptop it show passed to all test after editing .

jennethydyrova · 2025-10-27T08:59:22Z

Looks good to me, good job! Regarding not having same code on both computers, double check if you pull all changes from branch. If you work on one laptop and then continue on another one, your changes will not be automatically pulled.

Alaa-Tagi added 20 commits October 9, 2025 19:31

build up getAngleType case by case

b5de08b

Editing is-proper-fraction code

b5fa562

Editing getcardvalue code

3898643

rewrite test with jest for getangletype code

78d374a

update isproperfraction code

d07dd99

Rewrite test with jest for isproperfraction code

a223e45

rewrite test with jest for getcardvalue code

ef42f92

Editing count code

b02a77f

Editing count.js code

3f11ed4

Rewrite tests with jest for count code

d7507ff

Editing getordinalnumber code

2eaa92c

Rewrite tests with jest for getordinalnumber code

73c8fcf

Editing repeat code

52660c9

Rewrite test with jest for repeat code

408f2e1

1-get-angle-type.js

1f0b098

2-is-proper-fraction.js

d276533

3-get-card-value.js

ce08a1f

1-get-angle-type.test.js

874c5ca

3-get-card-value.test.js

ea944a1

2-is-proper-fraction.test.js

d25945b

Alaa-Tagi added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Oct 12, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2025

jennethydyrova suggested changes Oct 23, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 23, 2025

Alaa-Tagi added 2 commits October 24, 2025 19:02

Removes all console logs from PR

5e24460

Editing the code and jest code

d269acc

Alaa-Tagi added 5 commits October 24, 2025 19:21

Editing jest code

62bf3a9

update the code

6f9d56b

Write additional tests

b1c0345

Correct the code

8ff02d3

Add another tests

2aafdb6

Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 24, 2025

jennethydyrova suggested changes Oct 26, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

Alaa-Tagi added 2 commits October 26, 2025 21:40

Remove all console logs

c491953

editing the code

0f0c704

Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 26, 2025

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 26, 2025

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

Alaa-Tagi added 3 commits October 26, 2025 23:55

fixing the code to run the jest test

9e74422

Deleting line to fix the code

099a76f

editing the code

2db8252

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 27, 2025

Alaa-Tagi mentioned this pull request Oct 30, 2025

25-ITP-SEP | Structuring and testing data | Alaa Tagi Alaa-Tagi/My-Coursework-Planner#66

Open

Uh oh!

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 3 | Coursework/sprint 3 practice tdd #758

Are you sure you want to change the base?

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 3 | Coursework/sprint 3 practice tdd #758

Uh oh!

Conversation

Alaa-Tagi commented Oct 12, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alaa-Tagi commented Oct 27, 2025

Uh oh!

jennethydyrova commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jennethydyrova Oct 26, 2025 •

edited

Loading

jennethydyrova Oct 26, 2025 •

edited

Loading