-
-
Notifications
You must be signed in to change notification settings - Fork 262
Glasgow | 25-ITP-SEP | Mohammed Abdoon | Sprint 3 | Coursework/1-implement-and-rewrite-tests #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 8 commits
aa5dc2a
a805d98
4b4d8da
ba6d069
79156df
049c628
6cd7b35
d489ca1
123c3c2
7a3bb54
4e2d6be
7e35093
f8f268c
35475f7
76a034c
effa3b4
8237ab8
2214586
8e2e5eb
37aedba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| node_modules | ||
| .DS_Store | ||
| .vscode | ||
| testing.js | ||
| **/.DS_Store |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,9 +8,17 @@ | |
| // write one test at a time, and make it pass, build your solution up methodically | ||
| // just make one change at a time -- don't rush -- programmers are deep and careful thinkers | ||
| function getCardValue(card) { | ||
| let rank = card.slice(0, -1); | ||
| if (rank === "A") { | ||
| return 11; | ||
| } | ||
| if (rank === "J" || rank === "Q"|| rank === "K") { | ||
| return 10; | ||
| } | ||
| if ((rank => 2) && (rank <= 10)) { | ||
| return Number(rank); | ||
| } | ||
|
||
| return "Invalid card rank."; | ||
| } | ||
|
|
||
| // The line below allows us to load the getCardValue function into tests in other files. | ||
|
|
@@ -40,18 +48,25 @@ assertEquals(aceofSpades, 11); | |
| // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5). | ||
| const fiveofHearts = getCardValue("5♥"); | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
| assertEquals(fiveofHearts, 5); | ||
|
|
||
| // Handle Face Cards (J, Q, K): | ||
| // Given a card with a rank of "10," "J," "Q," or "K", | ||
| // When the function is called with such a card, | ||
| // Then it should return the value 10, as these cards are worth 10 points each in blackjack. | ||
| const faceCards = getCardValue("J♠"); | ||
| assertEquals(faceCards, 10); | ||
|
|
||
| // Handle Ace (A): | ||
| // Given a card with a rank of "A", | ||
| // When the function is called with an Ace, | ||
| // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack. | ||
| const ace = getCardValue("A♠"); | ||
| assertEquals(ace, 11); | ||
|
|
||
| // Handle Invalid Cards: | ||
| // Given a card with an invalid rank (neither a number nor a recognized face card), | ||
| // When the function is called with such a card, | ||
| // Then it should throw an error indicating "Invalid card rank." | ||
| const invalidCards = getCardValue("hello"); | ||
| assertEquals(invalidCards, "Invalid card rank."); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,18 +9,18 @@ test("should identify right angle (90°)", () => { | |
| // REPLACE the comments with the tests | ||
| // make your test descriptions as clear and readable as possible | ||
|
|
||
| // Case 2: Identify Acute Angles: | ||
| // When the angle is less than 90 degrees, | ||
| // Then the function should return "Acute angle" | ||
| test("should identify Acute angle (less than 90°)", () => { | ||
| expect(getAngleType(80)).toEqual("Acute angle"); | ||
| }); | ||
|
|
||
| // Case 3: Identify Obtuse Angles: | ||
| // When the angle is greater than 90 degrees and less than 180 degrees, | ||
| // Then the function should return "Obtuse angle" | ||
| test("should identify Obtuse angle (greater than 90° and less than 180 )", () => { | ||
| expect(getAngleType(100)).toEqual("Obtuse angle"); | ||
| }); | ||
|
|
||
| // Case 4: Identify Straight Angles: | ||
| // When the angle is exactly 180 degrees, | ||
| // Then the function should return "Straight angle" | ||
| test("should identify Straight angle (180°)", () => { | ||
| expect(getAngleType(180)).toEqual("Straight angle"); | ||
| }); | ||
|
|
||
| // Case 5: Identify Reflex Angles: | ||
| // When the angle is greater than 180 degrees and less than 360 degrees, | ||
| // Then the function should return "Reflex angle" | ||
| test("should identify Reflex angle (greater than 180° and less than 360°)", () => { | ||
| expect(getAngleType(181)).toEqual("Reflex angle"); | ||
| }); | ||
|
Comment on lines
28
to
32
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could specify multiple |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,16 @@ test("should return true for a proper fraction", () => { | |
| }); | ||
|
|
||
| // Case 2: Identify Improper Fractions: | ||
| test("should return false for an improper Fractions", () => { | ||
| expect(isProperFraction(9, 4)).toEqual(false); | ||
| }); | ||
|
|
||
| // Case 3: Identify Negative Fractions: | ||
| test("should return true for a negative Fractions", () => { | ||
| expect(isProperFraction(-6, 4)).toEqual(true); | ||
| }); | ||
|
||
|
|
||
| // Case 4: Identify Equal Numerator and Denominator: | ||
| test("should return false for an equal Fractions", () => { | ||
| expect(isProperFraction(7, 7)).toEqual(false); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,25 @@ test("should return 11 for Ace of Spades", () => { | |
| }); | ||
|
|
||
| // Case 2: Handle Number Cards (2-10): | ||
| test("should return the number entered as input", () => { | ||
| const numberCards = getCardValue("4♠"); | ||
| expect(numberCards).toEqual(4); | ||
| }); | ||
|
|
||
|
Comment on lines
11
to
16
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual card, we will need about 53 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples. For example, one possible category for
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok. I changed the code and added more test cases + added different statements using for loop to test numbers from 2 to 10 |
||
| // Case 3: Handle Face Cards (J, Q, K): | ||
| test("should return 10 for face cards J Q K", () => { | ||
| const faceCards = getCardValue("Q♠"); | ||
| expect(faceCards).toEqual(10); | ||
| }); | ||
|
|
||
| // Case 4: Handle Ace (A): | ||
| test("should return 11 after entering Ace A", () => { | ||
| const handleAce = getCardValue("A♠"); | ||
| expect(handleAce).toEqual(11); | ||
| }); | ||
|
|
||
| // Case 5: Handle Invalid Cards: | ||
| test(`should return string ("Invalid card rank.") for invalid inputs`, () => { | ||
| const invalidCards = getCardValue("HelloWorld!"); | ||
| expect(invalidCards).toEqual("Invalid card rank."); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let output = 0; | ||
| for( let i=0; i <= stringOfCharacters.length; i++ ) { | ||
| if(stringOfCharacters[i] === findCharacter) | ||
| output++; | ||
| } | ||
| return output; | ||
| } | ||
|
|
||
| module.exports = countChar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In mathematics, -A/B == A/-B == -(A/B), and -A/-B == A/B for any integers A and B (B ≠ 0).
They represent a proper fraction if A < B and B ≠ 0.
So
isProperFraction(-4, 3)should returnfalsebecause 4 >= 3.So
isProperFraction(-2, 5)should returntruebecause 2 < 5.Consider comparing the absolute value of the numerator and the denominator instead.
In addition, to indicate errors, it is best practices to throw an error (instead of returning an error message).
If you have time, you should check out how to throw an error in JS.
Alternatively, you can choose to return
falseto indicate something is not a fraction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the required changes, I used the method Math.abs() to fix the bug and used error throwing when inputs are not valid. also the function should return 0 when denominator is 0;