London | Sep-2025 | Gislaine Della Bella | Structuring and Testing Data | Sprint-1 #739

Della-Bella · 2025-10-07T18:52:27Z

Learners, PR Template

Self checklist

[x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[x ] My changes meet the requirements of the task
[x ] I have tested my changes
[x ] My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Thank you for your time to review my code 👩🏻‍💻

slice() Math.floor() Math.random() lastIndexOf() replaceAll()

dquote>

github-actions · 2025-10-07T18:52:44Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-07T18:53:19Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-14T19:36:02Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-14T19:36:08Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova

Hi @Della-Bella! Great effort working through these exercises!

A few things to work on in this PR and in all subsequent ones:

Proofread your answers - there are quite a few typos that make your explanations harder to follow. A quick review can make a big difference!
Clean up your code - please remove:
- Unused/commented-out code and scratch work
- Personal note comments
- package-lock.json file (this should never be committed to the codebase as it's a very large file and doesn't need to be here)

This keeps your PRs clean and makes your code easier for others to understand.

I've left specific comments on individual questions. Keep up the good work! 💪

jennethydyrova · 2025-10-14T19:40:09Z

Sprint-1/1-key-exercises/1-count.js

 // Line 1 is a variable declaration, creating the count variable with an initial value of 0
 // Describe what line 3 is doing, in particular focus on what = is doing
+
+//line 3 is a statment. It is adding 1 to the value of the variable count 


Good observation about the addition! One thing to refine: is = doing the adding or is it doing something else? What's the difference between + and = in this line?

hi @jennethydyrova ,
the + is adding and the = is Assing the new valeu to the variable "count

jennethydyrova · 2025-10-14T19:44:24Z

Sprint-1/1-key-exercises/2-initials.js

-let initials = ``;

-// https://www.google.com/search?q=get+first+character+of+string+mdn
+let initials= `${firstName.charAt(0)} ${middleName.charAt(0)} ${lastName.charAt(0)}`;


Your initials variable will hold "C K J" value, does it exactly match the requirement?

I left a "test"i was seeying if it was working. Now I hae deleted it and the out put is : C K J
;)

Please see output requirement on L4. Does your output match the requirement?

I got the error now. I removed the spaces on CJK. ;)

jennethydyrova · 2025-10-14T19:45:22Z

Sprint-1/1-key-exercises/2-initials.js

+let initialsSecond = `${firstName.charAt(3)} ${middleName.charAt(2)} ${lastName.charAt(4)}`;
+
+console.log (initials, initialsSecond);


Is this needed for the solution? If not, let's remove it to keep the PR focused.

agree, i was practising some changes and forgot to delete it.

jennethydyrova · 2025-10-14T19:46:48Z

Sprint-1/1-key-exercises/3-paths.js


 // (All spaces in the "" line should be ignored. They are purely for formatting.)
-
+                  //home / user /dir /                          file.txt; 


Same as previous comment, is this and everything after line 27 needed for the solution? If not, let's remove it to keep the PR focused.

jennethydyrova · 2025-10-14T20:02:33Z

Sprint-1/1-key-exercises/4-random.js

+//(maximum - minimum + 1) = get maximum number 100 extract the minimum 1 add +1 to incluide 100.
+//+ minimum add 1
+
+//math.radom = gets randm number between 0 and 1 but never 1 so we add +1 to incluide 1


You're onto something here, but I think you're mixing two ideas. Math.random() never returning 1 is true, but that's not why we have +1 in the formula. What would happen if the formula was Math.random() * (maximum - minimum) + minimum? Try it with max=100, min=1. What range of numbers would you actually get?

@Della-Bella you might have skipped this comment

hi Jennete, I modified the code without the -1 and got it would never get 100 random would go up to 99. got t know. So the +1 is essential to the maximum value can be 100. thank you

jennethydyrova · 2025-10-14T20:27:04Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+// 8760 / 60 equals 146 minutes

 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// represents how long in time is the movie. could be caled= const timeMovie


Good thinking about naming! Look at how other variables are named in this code (like totalMinutes). Can you make "timeMovie" follow the same naming style? (Hint: in JS naming convention for variables usually follows descriptor + noun pattern)

maybe movieTotalLength

jennethydyrova · 2025-10-14T20:31:15Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+// i guess it wouldnt worrk for negative numbers but actualy evething envolves time is dificult to 
+//my mind explain. I need to search for more simples expamples to associete this Reminder operetar in time.
+// this was a dificult mind flows to me :(


Good catch on negative numbers!

jennethydyrova · 2025-10-14T20:40:07Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+// so sbtstring start form 0 and the length has 3 = 399
+
+
+// line 8. We declare variale "const paddedPenceNumberString" make sure the number number has least 3 digits


You said padStart "makes sure the number has at least 3 digits", that's correct. But why do we need exactly 3 digits? Try running the code with penceString = "9p" and trace through what happens.

it "fills" 0.09p add the 0,0 to be sure it has 3 digits for money format.

jennethydyrova · 2025-10-14T20:42:53Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+
+/// lines 14 to 16= const to the pence: the start indext for Substring will be 3-2= 1
+// substring with 1 argument wil start on the given indes and goes until the end = 99
+// padending (2, "0") will keep only 2 digits =99


I think you might be confusing what padEnd does. You said it "will keep only 2 digits = 99". Does it remove digits, or does it do something else? What happens if the string is already 2 characters long vs. if it's only 1 character? Maybe try an example to see.

true i got confused . padend make sure the pence part has 2 digits. if it dosen;t padend will add the 0 to it. if it has already 2 digits will stay the same

jennethydyrova · 2025-10-14T20:56:06Z

Sprint-1/2-mandatory-errors/3.js

+// it will not work becase Slice is a string methodo. 
+// To work here need to convert the number to string 


Thanks, @jennethydyrova, for your time reviewing my work. Ib will remember about the extra and personal coments. Make the PR's clear ;)

github-actions · 2025-10-14T21:03:54Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-14T21:03:54Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova · 2025-10-17T10:04:39Z

Hi @Della-Bella! I've left a couple more comments, but I just noticed you haven't changed the label to "Needs Review" yet. Feel free to disregard them if you're still working on the PR, happy to take another look once you're ready!

github-actions · 2025-11-16T10:42:34Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-16T10:42:36Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova

Hi @Della-Bella! I see you made some changes but you still haven't addressed quite a few of my comments. I didn't point out to all of them in this round of review but please go over each comment and try to resolve them. Also, please make sure you reduce number of typos in your work, there are quite a few of them.

jennethydyrova · 2025-11-21T14:25:58Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

+// 3 functions:
+// carPrice = Number(carPrice.replaceAll(",", ""));
+// priceAfterOneYear = Number(priceAfterOneYear.replaceAll("," ""));
+// const percentageChange = (priceDifference / carPrice) * 100;


is this a function call?

jennethydyrova · 2025-11-21T14:26:21Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

+// const percentageChange = (priceDifference / carPrice) * 100;

 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
+//Error was in line 5 missing a coman between the get to replace ""


typo in comma

jennethydyrova · 2025-11-21T14:28:35Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

+// lines 1 and 2 , 7 and 8

 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+// it is converting the numbers prices to real numbers replace the commnas to empty string so takrs the commans out


I think you missed this comment. Your explanation just reads the line but doesn't explain what it actually does.

jennethydyrova · 2025-11-21T14:29:27Z

Sprint-1/3-mandatory-interpret/2-time-format.js

 // For the piece of code above, read the code and then answer the following questions

 // a) How many variable declarations are there in this program?
+// 4 on lines : 1, 3 and 6 and 9


Same, this comment is not addressed.

github-actions · 2025-11-21T14:32:27Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-21T14:32:27Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

jennethydyrova · 2025-11-21T14:33:19Z

Another point, you shouldn't change label to Complete on your own. When you have done changes and want another review, you should change label to Needs review, which will signal me that I need to review your PR one more time.

Della-Bella added 6 commits October 1, 2025 23:55

Practicing charAt(), slice()

9fb5c1d

practicing charAt()

6732232

slice() Math.floor() Math.random() lastIndexOf() replaceAll()

charAt()

e9af9ad

slice() Math.floor() Math.random() lastIndexOf() replaceAll()

Reminder operator practice

4d88962

dquote>

padStart, subString string.lenght Practice

8a5ee4b

stretch

9f1d381

Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 7, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 14, 2025

jennethydyrova suggested changes Oct 14, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 14, 2025

Excerccises Reviews

9caae05

Della-Bella added 2 commits November 16, 2025 10:29

Remove the spaces in CJK

9aa96a7

Check what the value " +1" represent in the code

9cc5c5f

Della-Bella added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 16, 2025

jennethydyrova suggested changes Nov 21, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Nov 21, 2025

		let initialsSecond = `${firstName.charAt(3)} ${middleName.charAt(2)} ${lastName.charAt(4)}`;

		console.log (initials, initialsSecond);


		// (All spaces in the "" line should be ignored. They are purely for formatting.)

		//home / user /dir / file.txt;

		// so sbtstring start form 0 and the length has 3 = 399


		// line 8. We declare variale "const paddedPenceNumberString" make sure the number number has least 3 digits

		// it will not work becase Slice is a string methodo.
		// To work here need to convert the number to string

Uh oh!

London | Sep-2025 | Gislaine Della Bella | Structuring and Testing Data | Sprint-1 #739

Are you sure you want to change the base?

London | Sep-2025 | Gislaine Della Bella | Structuring and Testing Data | Sprint-1 #739

Uh oh!

Conversation

Della-Bella commented Oct 7, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

jennethydyrova commented Oct 17, 2025

Uh oh!

github-actions bot commented Nov 16, 2025

Uh oh!

github-actions bot commented Nov 16, 2025

Uh oh!

jennethydyrova Oct 14, 2025 •

edited

Loading

jennethydyrova commented Nov 21, 2025 •

edited

Loading