Skip to content

London | 25-SDC-July | Ali Qassab | Module-Legacy-Code | Sprint 1 | Hashtag link doesn't work correctly #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Ali Qassab | Module-Legacy-Code | Sprint 1 | Hashtag link doesn't work correctly #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions front-end/components/bloom.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ const createBloom = (template, bloom) => {
function _formatHashtags(text) {
if (!text) return text;
return text.replace(
/\B#[^#]+/g,
/\B#\w+/g,
Copy link

@mjpeet mjpeet Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work for fixing this bug! The solution is precise, well-reasoned, and demonstrates solid understanding of regex patterns and how hashtags should behave.

// /\B#[^#]+/g,
Copy link

@mjpeet mjpeet Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we don't leave comments like this in the code (this is why git is there - to track changes)

(match) => `<a href="/hashtag/${match.slice(1)}">${match}</a>`
);
}
Expand Down Expand Up @@ -84,4 +85,4 @@ function _formatTimestamp(timestamp) {
}
}

export {createBloom};
export { createBloom };