Skip to content

Person1 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Person1 #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dom-merge-conflict/tasks/conditional-rendering/src/profilePreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
export function ProfilePreview(profile) {
export function ProfilePreview(profile, options) {
const preview = document.createElement("aside");
if (options && options.available === false) {
const unavailable = document.createElement("p");
unavailable.textContent = "Profile preview unavailable";
preview.appendChild(unavailable);
return preview;
}

const picture = document.createElement("img");
picture.src = profile.pictureSrc;
Expand Down
2 changes: 1 addition & 1 deletion dom-merge-conflict/tasks/conditional-rendering/test/profilePreview.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe("profile preview", () => {
});
});

describe.skip("available option", () => {
describe("available option", () => {
test("only notice that preview is unavailable is displayed with shortform on, available off", () => {
const profile = {
pictureSrc: "/null",
Expand Down