Skip Mockcache on disallowed direct cache call

Author: paulbalandan

src/Rules/Classes/CacheHandlerInstantiationRule.php

@@ -15,6 +15,7 @@
 
 use CodeIgniter\Cache\CacheFactory;
 use CodeIgniter\Cache\CacheInterface;
+use CodeIgniter\Test\Mock\MockCache;
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
@@ -51,6 +52,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($reflection->getName() === MockCache::class) {
+            return [];
+        }
+
         if ($scope->isInClass() && $scope->getClassReflection()->getName() === CacheFactory::class) {
             return [];
         }

tests/Fixtures/Rules/Classes/cache-handler.php

@@ -13,10 +13,13 @@
 
 use CodeIgniter\Cache\Handlers\FileHandler;
 use CodeIgniter\Cache\Handlers\RedisHandler;
+use CodeIgniter\Test\Mock\MockCache;
 use Config\Cache;
 
 $handler1 = new FileHandler(new Cache());
 $handler2 = new RedisHandler(new Cache());
+$handler3 = new MockCache();
 
 $cache1 = $handler1->get('foo');
 $cache2 = $handler2->get('bar');
+$cache3 = $handler3->get('baz');

tests/Rules/Classes/CacheHandlerInstantiationRuleTest.php

@@ -39,12 +39,12 @@ public function testRule(): void
         $this->analyse([__DIR__ . '/../../Fixtures/Rules/Classes/cache-handler.php'], [
             [
                 'Calling new FileHandler() directly is incomplete to get the cache instance.',
-                18,
+                19,
                 'Use CacheFactory::getHandler() or the cache() function to get the cache instance instead.',
             ],
             [
                 'Calling new RedisHandler() directly is incomplete to get the cache instance.',
-                19,
+                20,
                 'Use CacheFactory::getHandler() or the cache() function to get the cache instance instead.',
             ],
         ]);