Fix check on variable assign inside Superglobals

paulbalandan · paulbalandan · commit f4c4ec519451 · 2023-08-27T16:43:54.000+08:00
diff --git a/src/Rules/Superglobals/SuperglobalAssignRule.php b/src/Rules/Superglobals/SuperglobalAssignRule.php
@@ -145,6 +145,10 @@ private function processVariableExpr(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($scope->isInClass() && $scope->getClassReflection()->getName() === Superglobals::class) {
+            return [];
+        }
+
         $exprType = $scope->getType($node->expr);
 
         if (! $exprType->isArray()->yes()) {

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,10 @@ private function processVariableExpr(Node $node, Scope $scope): array`
`145`	`145`	`return [];`
`146`	`146`	`}`
`147`	`147`
	`148`	`+ if ($scope->isInClass() && $scope->getClassReflection()->getName() === Superglobals::class) {`
	`149`	`+ return [];`
	`150`	`+ }`
	`151`	`+`
`148`	`152`	`$exprType = $scope->getType($node->expr);`
`149`	`153`
`150`	`154`	`if (! $exprType->isArray()->yes()) {`