Skip to content

fix: confusing message display when upload size was greater than the … #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

fix: confusing message display when upload size was greater than the … #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/app/upload/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,23 @@ export default function Page() {
return;
}

const totalSize = allFiles.reduce(
(sum, f) => sum + f.size,
0,
);
if (totalSize > maxFileSize){
toast.error("The total upload size exceeds 5MB.", { id: toastId });
return;
}

const invalidFiles = acceptedFiles.filter(
(file) =>
file.size > maxFileSize || !allowedFileTypes.includes(file.type),
);

if (invalidFiles.length > 0) {
toast.error(
"Some files are invalid. Make sure each is under 5MB and of allowed types (PDF, JPEG, PNG, GIF).",
"Some files are invalid. Make sure the total size is below 5MB and files are of allowed types (PDF, JPEG, PNG, GIF).",
{ id: toastId },
);
return;
Expand Down