chore: update readme, return correct error text if round not enabled #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustyDev24
reviewed
Jul 31, 2025
internal/middlewares/round_check.go
Outdated
|
|
||
| if user.RoundQualified != int32(roundVal) { | ||
| httphelpers.WriteError(w, http.StatusForbidden, "not qualified") | ||
| httphelpers.WriteError(w, http.StatusForbidden, "round not enabled yet") |
Contributor
There was a problem hiding this comment.
what if round 2 is enabled and user was not qualified for it so their round is 1
Author
There was a problem hiding this comment.
There's "User is not qualified for this round" error for that (in preview questions and other routes.) Unless this is being used in the frontend to tell whether the user is qualified for the round, it shouldn't be an issue.
I guess a better solution would be to put up a seperate middleware to tell whether the round is enabled or not, otherwise this error is misleading.
Contributor
There was a problem hiding this comment.
Round being enabled was a check from the frontend this time round
that's why we only check for qualification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.