Fix tuple append row handling to gracefully accept empty structs. #1721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AppendRow fails with conversion error if the value of the tuple field is a nil pointer. This is a problem when inserting from protobuf using optional nested messages, when these are not given a value.
Example error:
This change allows for graceful handling of empty structs.
Full example here: https://gist.github.com/jtmolon/569f5a37bed17620c4c976baee0eb7ab
Checklist
Delete items not relevant to your PR: