rft: clean up surface code #4120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2025
haakon-e
force-pushed
the
he/rft-clean-surface-code
branch
from
da52bea to
86340ad
Compare
szy21
reviewed
Nov 26, 2025
| ), | ||
| ) | ||
| ᶜe_tot = @. lazy(specific(Y.c.ρe_tot, Y.c.ρ)) | ||
| ᶜh_tot = @. lazy(TD.total_specific_enthalpy(thermo_params, ᶜts, ᶜe_tot)) |
Member
There was a problem hiding this comment.
I don't think this change is necessary, but I am ok with it (we have the same ᶜh_tot calculation in a lot of other places and it would be good to be consistent).
Member
Author
There was a problem hiding this comment.
I agree that it's not necessary, but I think it makes the code more readable. Happy to change back if you prefer the existing way though (I'm also happy to change this everywhere else for the sake of consistency)
Member
There was a problem hiding this comment.
ok let's change here and elsewhere then, thanks!
szy21
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily refactors and cleans up the code in the surface conditions and surface flux modules, focusing on improving readability and maintainability without changing core logic. The changes involve consolidating multi-line expressions into single lines, improving destructuring and broadcasting, and removing unnecessary variables. There are no significant algorithmic or behavioral changes.
Key refactoring and cleanup changes:
Surface conditions module (
src/surface_conditions/surface_conditions.jl):cospifor surface temperature calculation, simplifying trigonometric expressions.Surface state module (
src/surface_conditions/surface_state.jl):Surface flux tendency (
src/prognostic_equations/surface_flux.jl):These changes are focused on code style and maintainability, making the codebase easier to read and modify without altering its functionality.