-
Notifications
You must be signed in to change notification settings - Fork 27
rft: smagorinsky-lilly for future h-v splitting #4074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Oct 24, 2025
6be1adf to
80820b8
Compare
f208904 to
5b71280
Compare
80820b8 to
cfe233d
Compare
096387a to
c5146ea
Compare
cfe233d to
706a428
Compare
5735cee to
87a105c
Compare
Member
Author
|
buildkite should pass once #4072 is merged so that ClimaCore is bumped to |
87a105c to
2469091
Compare
706a428 to
c8317c7
Compare
2469091 to
8c5c1b8
Compare
trontrytel
reviewed
Oct 27, 2025
trontrytel
reviewed
Oct 27, 2025
trontrytel
reviewed
Oct 27, 2025
trontrytel
reviewed
Oct 27, 2025
src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl
Outdated
Show resolved
Hide resolved
trontrytel
reviewed
Oct 27, 2025
src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl
Outdated
Show resolved
Hide resolved
trontrytel
reviewed
Oct 27, 2025
src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl
Outdated
Show resolved
Hide resolved
trontrytel
reviewed
Oct 27, 2025
trontrytel
approved these changes
Oct 27, 2025
c8317c7 to
e5987ed
Compare
8c5c1b8 to
ec7aa18
Compare
ec7aa18 to
a82a107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and extends the Smagorinsky-Lilly subgrid turbulence model implementation, making it more flexible and adding diagnostics and configuration options. The model can now be applied in specific directions (currently only
UVW, i.e., all directions), and new diagnostics for horizontal and vertical diffusivities and strain rates are available. The changes affect configuration files, model initialization, diagnostics, and the main turbulence model code.Key changes:
Smagorinsky-Lilly Model Refactor and Extension
SmagorinskyLillytype to a parametric struct (SmagorinskyLilly{DIR}), allowing specification of which directions the model applies to (currently only:UVWis supported). Added utility functions to check model directionality, enabling more flexible and explicit control over turbulence modeling.Diagnostics and Postprocessing
Dh_smag,Dv_smag) and strain rate magnitudes (strainh_smag,strainv_smag). These are now available for output and analysis.Configuration and Model Selection
"UVW"(all directions) ornothing(disabled), replacing the previous boolean flag. Updated model getter logic to parse and instantiate the correct model variant. [1] [2] [3] [4]Integration with Other Model Components
Minor Improvements
These changes collectively make the turbulence modeling more flexible, improve diagnostics, and streamline configuration and code structure.