Added global ID formatter conditionally (#8684)

Author: glen-84

src/HotChocolate/Data/src/Data/Filters/Extensions/RelayIdFilterFieldExtensions.cs

@@ -1,6 +1,7 @@
 using HotChocolate.Configuration;
 using HotChocolate.Language;
 using HotChocolate.Types;
+using HotChocolate.Types.Relay;
 using HotChocolate.Utilities;
 
 namespace HotChocolate.Data.Filters;
@@ -31,9 +32,12 @@ public static IFilterOperationFieldDescriptor ID(
             .Extend()
             .OnBeforeCompletion((c, d) =>
             {
-                var returnType = d.Member is null ? typeof(string) : d.Member.GetReturnType();
-                var returnTypeInfo = c.DescriptorContext.TypeInspector.CreateTypeInfo(returnType);
-                d.Formatters.Push(CreateSerializer(c, returnTypeInfo.NamedType));
+                if (c.Features.Get<NodeSchemaFeature>()?.IsEnabled == true)
+                {
+                    var returnType = d.Member is null ? typeof(string) : d.Member.GetReturnType();
+                    var returnTypeInfo = c.DescriptorContext.TypeInspector.CreateTypeInfo(returnType);
+                    d.Formatters.Push(CreateSerializer(c, returnTypeInfo.NamedType));
+                }
             });
 
         return descriptor;

src/HotChocolate/Data/test/Data.Filters.Tests/FilterInputTypeTest.cs

@@ -377,6 +377,53 @@ public void FilterInputType_Should_InfereType_When_ItIsAInterface()
         schema.MatchSnapshot();
     }
 
+    [Fact]
+    public void FilterInputType_WithGlobalObjectIdentification_AppliesGlobalIdFormatter()
+    {
+        // arrange
+        var builder = SchemaBuilder.New()
+            .ModifyOptions(x => x.StrictValidation = false)
+            .AddGlobalObjectIdentification()
+            .AddFiltering()
+            .AddQueryType(
+                d => d
+                    .Field("books")
+                    .UseFiltering<BookFilterInput>()
+                    .Resolve(new List<Book>()));
+
+        // act
+        var schema = builder.Create();
+        var idFilterField = ((BookFilterInput)schema.Types[nameof(BookFilterInput)]).Fields["id"];
+
+        // assert
+        Assert.True(
+            ((IdOperationFilterInputType)idFilterField.Type).Fields.All(
+                f => f.Formatter is FilterGlobalIdInputValueFormatter));
+    }
+
+    [Fact]
+    public void FilterInputType_WithoutGlobalObjectIdentification_DoesNotApplyGlobalIdFormatter()
+    {
+        // arrange
+        var builder = SchemaBuilder.New()
+            .ModifyOptions(x => x.StrictValidation = false)
+            .AddFiltering()
+            .AddQueryType(
+                d => d
+                    .Field("books")
+                    .UseFiltering<BookFilterInput>()
+                    .Resolve(new List<Book>()));
+
+        // act
+        var schema = builder.Create();
+        var idFilterField = ((BookFilterInput)schema.Types[nameof(BookFilterInput)]).Fields["id"];
+
+        // assert
+        Assert.True(
+            ((IdOperationFilterInputType)idFilterField.Type).Fields.All(
+                f => f.Formatter is not FilterGlobalIdInputValueFormatter));
+    }
+
     [Fact]
     public async Task Execute_CoerceWhereArgument_MatchesSnapshot()
     {
@@ -608,4 +655,12 @@ public class FilterWithStruct
     }
 
     public record struct ExampleValueType(string Foo, string Bar);
+
+    private class BookFilterInput : FilterInputType<Book>
+    {
+        protected override void Configure(IFilterInputTypeDescriptor<Book> descriptor)
+        {
+            descriptor.Field(b => b.Id).Type<IdOperationFilterInputType>();
+        }
+    }
 }