Added a separate pagination error message for missing first value (#8693)

Author: glen-84

src/HotChocolate/Core/src/Types.CursorPagination/CursorPagingHandler.cs

@@ -60,7 +60,14 @@ public void ValidateContext(IResolverContext context)
 
         if (RequirePagingBoundaries && first is null && last is null)
         {
-            throw ThrowHelper.PagingHandler_NoBoundariesSet(
+            if (AllowBackwardPagination)
+            {
+                throw ThrowHelper.PagingHandler_NoBoundariesSet(
+                    context.Selection.Field,
+                    context.Path);
+            }
+
+            throw ThrowHelper.PagingHandler_FirstValueNotSet(
                 context.Selection.Field,
                 context.Path);
         }

src/HotChocolate/Core/src/Types.CursorPagination/Properties/CursorResources.Designer.cs

@@ -42,6 +42,9 @@
   <data name="ThrowHelper_PagingHandler_NoBoundariesSet" xml:space="preserve">
     <value>You must provide a `first` or `last` value to properly paginate the `{0}`.</value>
   </data>
+  <data name="ThrowHelper_PagingHandler_FirstValueNotSet" xml:space="preserve">
+    <value>You must provide a `first` value to properly paginate the `{0}`.</value>
+  </data>
   <data name="Edge_Cursor_CursorAndResolverNull" xml:space="preserve">
     <value>The edge state is invalid and has no cursor.</value>
   </data>

src/HotChocolate/Core/src/Types.CursorPagination/Properties/CursorResources.resx

@@ -47,6 +47,19 @@ public static GraphQLException PagingHandler_NoBoundariesSet(
                 .SetFieldCoordinate(field.Coordinate)
                 .Build());
 
+    public static GraphQLException PagingHandler_FirstValueNotSet(
+        IOutputFieldDefinition field,
+        Path path)
+        => new GraphQLException(
+            ErrorBuilder.New()
+                .SetMessage(
+                    ThrowHelper_PagingHandler_FirstValueNotSet,
+                    field.Type.TypeName())
+                .SetCode(ErrorCodes.Paging.FirstValueNotSet)
+                .SetPath(path)
+                .SetFieldCoordinate(field.Coordinate)
+                .Build());
+
     public static SchemaException PagingObjectFieldDescriptorExtensions_InvalidType()
         => new SchemaException(
             SchemaErrorBuilder.New()

src/HotChocolate/Core/src/Types.CursorPagination/Utilities/ThrowHelper.cs

@@ -115,6 +115,32 @@ await executor
             .MatchSnapshotAsync();
     }
 
+    [Fact]
+    public async Task First_Value_Not_Set()
+    {
+        var executor =
+            await new ServiceCollection()
+                .AddGraphQL()
+                .AddQueryType<QueryType>()
+                .ModifyPagingOptions(o =>
+                {
+                    o.RequirePagingBoundaries = true;
+                    o.AllowBackwardPagination = false;
+                })
+                .Services
+                .BuildServiceProvider()
+                .GetRequestExecutorAsync();
+
+        await executor
+            .ExecuteAsync(@"
+                {
+                    letters {
+                        nodes
+                    }
+                }")
+            .MatchSnapshotAsync();
+    }
+
     [Fact]
     public async Task Attribute_Simple_StringList_Default_Items()
     {

src/HotChocolate/Core/test/Types.CursorPagination.Tests/IntegrationTests.cs

@@ -0,0 +1,23 @@
+{
+  "errors": [
+    {
+      "message": "You must provide a `first` value to properly paginate the `LettersConnection`.",
+      "locations": [
+        {
+          "line": 3,
+          "column": 21
+        }
+      ],
+      "path": [
+        "letters"
+      ],
+      "extensions": {
+        "code": "HC0090",
+        "fieldCoordinate": "Query.letters"
+      }
+    }
+  ],
+  "data": {
+    "letters": null
+  }
+}

src/HotChocolate/Core/test/Types.CursorPagination.Tests/__snapshots__/IntegrationTests.First_Value_Not_Set.snap

@@ -354,6 +354,11 @@ public static class Paging
         /// </summary>
         public const string NoPagingBoundaries = "HC0052";
 
+        /// <summary>
+        /// You must provide a `first` value to properly paginate the connection.
+        /// </summary>
+        public const string FirstValueNotSet = "HC0090";
+
         /// <summary>
         /// The requested number of values per page must be at least 0.
         /// </summary>