Resource Tree Generator: Fix Resource Include Enum #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saalvage
force-pushed
the
fix/resource-tree-generator-type-include-enum
branch
from
381d743 to
cf67b53
Compare
Saalvage
force-pushed
the
fix/resource-tree-generator-type-include-enum
branch
from
cf67b53 to
7b8bcaa
Compare
Saalvage
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 3 independent commits/changes, please cherry-pick as needed!
ResX.Scriptswas 3 instead of 4, which meant it would forcefully include UIDs and scenes and vice-versa.ResXtoResI. Without any context and after some time has passed since working on it,ResXparsed in my mind asResourceExclude. I'm personally not a fan of the abbreviated enums in general, but I think at leastResIparses more naturally asResourceInclude. I also added some documentation to clarify. I'm not sure if this is considered a breaking change since it's only been included in pre-releases thus far.GodotSharp.SourceGenerators. I'm not sure if the current namespace was consciously decided on or just there as an unchanged default. The extension attributes always useGodotand the only other enum I could find (Scope) usesGodotSharp.SourceGenerators.