Remove Hash implementations for zkp types
#45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A breaking change was inadvertently introduced with the release of `rust-secp256k1-sys:0.4.2`. Anyone who had used `impl_array_newtype` for type `T` and had also implemented `hash::Hash` on `T` before version `0.4.2` would now come across a "conflicting implementations error" on version `0.4.2`.
luckysori
force-pushed
the
macros-are-hard
branch
from
54dcd06 to
7179a3a
Compare
Contributor
Author
|
Oops, didn't see #44. Nothing to see here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change was inadvertently introduced with the release of
rust-secp256k1-sys:0.4.2.Anyone who had used
impl_array_newtypefor typeTand had also implementedhash::HashonTbefore version0.4.2would now come across a "conflicting implementations error" on version0.4.2.