Skip to content

fix: add final declaration for inner class variables #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix: add final declaration for inner class variables #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions android/src/main/java/com/blitzapp/animatedsplash/animation/ObjectAnimation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ private void runNextHideAnimation(ObjectAnimation object) {
}
}

public void slideAnimation(ObjectAnimation object) {
public void slideAnimation(final ObjectAnimation object) {

View view = object.object.getImageView();

Expand Down Expand Up @@ -271,7 +271,7 @@ public void onAnimationRepeat(Animation animation) {

}

public void rotateAnimation(ObjectAnimation object) {
public void rotateAnimation(final ObjectAnimation object) {
View view = object.object.getImageView();

ObjectAnimator rotation = ObjectAnimator.ofFloat(view, View.ROTATION, startFromValue, endToValue);
Expand Down Expand Up @@ -303,7 +303,7 @@ public void onAnimationEnd(Animator animation) {
});
}

public void fadeAnimation(ObjectAnimation object) {
public void fadeAnimation(final ObjectAnimation object) {

View view = object.object.getImageView();
view.setAlpha(1);
Expand Down Expand Up @@ -341,7 +341,7 @@ public void onAnimationRepeat(Animator animation) {

}

public void scaleAnimation(ObjectAnimation object) {
public void scaleAnimation(final ObjectAnimation object) {
View view = object.object.getImageView();
ObjectAnimator scale = ObjectAnimator.ofPropertyValuesHolder(view,
PropertyValuesHolder.ofFloat("scaleX", fromXDelta, toXDelta),
Expand Down Expand Up @@ -376,7 +376,7 @@ public void onAnimationRepeat(Animator animation) {
});
}

public void slideHideAnimation(ObjectAnimation object) {
public void slideHideAnimation(final ObjectAnimation object) {

View view = object.object.getImageView();

Expand Down Expand Up @@ -408,7 +408,7 @@ public void onAnimationRepeat(Animation animation) {

}

public void rotateHideAnimation(ObjectAnimation object) {
public void rotateHideAnimation(final ObjectAnimation object) {
View view = object.object.getImageView();

ObjectAnimator rotation = ObjectAnimator.ofFloat(view, View.ROTATION, startFromValue, endToValue);
Expand All @@ -433,7 +433,7 @@ public void onAnimationEnd(Animator animation) {
});
}

public void fadeHideAnimation(ObjectAnimation object) {
public void fadeHideAnimation(final ObjectAnimation object) {

View view = object.object.getImageView();
view.setAlpha(1);
Expand Down Expand Up @@ -463,7 +463,7 @@ public void onAnimationRepeat(Animator animation) {
});
}

public void scaleHideAnimation(ObjectAnimation object) {
public void scaleHideAnimation(final ObjectAnimation object) {
View view = object.object.getImageView();
ObjectAnimator scale = ObjectAnimator.ofPropertyValuesHolder(view,
PropertyValuesHolder.ofFloat("scaleX", fromXDelta, toXDelta),
Expand Down