frontend/add-account: ask user to connect BitBox02 to continue #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
reviewed
Nov 30, 2023
thisconnect
approved these changes
Nov 30, 2023
Collaborator
thisconnect
left a comment
thisconnect
left a comment
There was a problem hiding this comment.
tested LGTM with suggestion
| return ( | ||
| <div className="text-center"> | ||
| {t('connectKeystore.promptNoName')} | ||
| </div> |
Collaborator
There was a problem hiding this comment.
diff --git a/frontends/web/src/routes/account/add/add.tsx b/frontends/web/src/routes/account/add/add.tsx
index a97d87496..62a4735b2 100644
--- a/frontends/web/src/routes/account/add/add.tsx
+++ b/frontends/web/src/routes/account/add/add.tsx
@@ -130,9 +130,9 @@ export const AddAccount = () => {
case 'select-coin':
if (supportedCoins.length === 0) {
return (
- <div className="text-center">
+ <Message type="info">
{t('connectKeystore.promptNoName')}
- </div>
+ </Message>
);
}
return (So it looks a bit more prominent:
Since watchonly, one can enter this screen without a keystore connected. If so, we ask the user to connect to proceed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since watchonly, one can enter this screen without a keystore connected. If so, we ask the user to connect to proceed.