-
Notifications
You must be signed in to change notification settings - Fork 145
File upload setup #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DecampsRenan
wants to merge
8
commits into
main
Choose a base branch
from
feat/file-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
File upload setup #634
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
59ce3ba
feat: add file upload on book cover
DecampsRenan c33ee79
feat: add missing error messages and translations
DecampsRenan aa46771
feat: add translations form uploading cover
DecampsRenan 512fe76
fix: remove unused import
DecampsRenan 2de90ef
fix: uplaod button and add missing examplee
DecampsRenan 0779948
feat: clean upload button component
DecampsRenan ef3bdef
fix: extract mime type
DecampsRenan 87cc5ca
fix: add default url for S3_BUCKET
DecampsRenan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import type { Meta } from '@storybook/react-vite'; | ||
| import { UploadIcon } from 'lucide-react'; | ||
|
|
||
| import { UploadButton } from '@/components/ui/upload-button'; | ||
|
|
||
| export default { | ||
| title: 'Upload Button', | ||
| } satisfies Meta<typeof UploadButton>; | ||
|
|
||
| export const Default = () => { | ||
| return ( | ||
| <UploadButton | ||
| uploadRoute="bookCover" | ||
| inputProps={{ | ||
| accept: 'image/png,image/jpeg,image/gif', | ||
| }} | ||
| onUploadSuccess={(file) => console.log('uploaded file', file)} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export const WithChildren = () => { | ||
| return ( | ||
| <div className="flex space-x-2"> | ||
| <UploadButton | ||
| uploadRoute="bookCover" | ||
| onUploadSuccess={(file) => console.log('uploaded file', file)} | ||
| > | ||
| <UploadIcon /> | ||
| Upload a new file | ||
| </UploadButton> | ||
|
|
||
| <UploadButton | ||
| uploadRoute="bookCover" | ||
| onUploadSuccess={(file) => console.log('uploaded file', file)} | ||
| > | ||
| Upload a new file | ||
| <UploadIcon /> | ||
| </UploadButton> | ||
|
|
||
| <UploadButton | ||
| uploadRoute="bookCover" | ||
| onUploadSuccess={(file) => console.log('uploaded file', file)} | ||
| > | ||
| Upload a new file | ||
| </UploadButton> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export const Disabled = () => { | ||
| return ( | ||
| <div className="flex space-x-2"> | ||
| <UploadButton | ||
| disabled | ||
| uploadRoute="bookCover" | ||
| onUploadSuccess={(file) => console.log('uploaded file', file)} | ||
| > | ||
| <UploadIcon /> | ||
| Upload a new file | ||
| </UploadButton> | ||
|
|
||
| <UploadButton | ||
| disabled | ||
| uploadRoute="bookCover" | ||
| onUploadSuccess={(file) => console.log('uploaded file', file)} | ||
| > | ||
| Upload a new file | ||
| <UploadIcon /> | ||
| </UploadButton> | ||
| </div> | ||
| ); | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.