-
-
Notifications
You must be signed in to change notification settings - Fork 914
Fixed crashing on machines with early windows 10 version #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mvanbeusekom can you review it please? |
mvanbeusekom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krll-kov,
First of all thank you very much for this contribution and apologies for the late reply.
I am hoping you are still willing to contribute, I have reviewed the PR and have some feedback that would be great if you can address (especially since I don't have access to an early Windows 10 machine).
permission_handler_windows/windows/permission_handler_windows_plugin.cpp
Outdated
Show resolved
Hide resolved
permission_handler_windows/windows/permission_handler_windows_plugin.cpp
Show resolved
Hide resolved
|
@mvanbeusekom this actually fixes 2 more problems now from here (with total of 3): m_positionChangedRevoker was defined but never actually used in the package, it only caused constant geo-location usage as soon as app is started, without even using any of the features of this package. It caused network lags, crashes and other staff, so fix is really helpful |
Fixed following issue: #1388
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.