Add security guidance for state parameter usage in authentication flows #8161
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that applications should not put URLs or sensitive data directly in the
stateparameter. Instead, use an identifier that references data stored in browser storage.Changes
Updated JSDoc comments for the
stateparameter in 5 request type definitions:msal-common:
CommonAuthorizationUrlRequest- authorization flowsCommonEndSessionRequest- logout flowsmsal-browser:
PopupRequest- popup authenticationRedirectRequest- redirect authenticationSsoSilentRequest- silent SSOGuidance Added
This pattern improves privacy by keeping potentially sensitive redirect URLs and application state out of the authorization request/response flow.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io/usr/local/bin/node node install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/137.0.7151.55/linux64/chrome-headless-shell-linux64.zip/usr/local/bin/node node install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.