Skip to content

Commit b085eb7

Browse files
committed
Fixed test_create_file_when_file_permission_is_too_long by passing in correct permission str
1 parent 0121c69 commit b085eb7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

azure-storage-file/azure/storage/file/_serialization.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ def _validate_and_return_file_permission(file_permission, file_permission_key, d
7777
# value as file permission, file_permission size should be <= 8KB, else file permission_key should be used
7878
empty_file_permission = file_permission is None or len(file_permission) == 0
7979
empty_file_permission_key = file_permission_key is None or len(file_permission_key) == 0
80-
file_permission_size_too_big = False if file_permission is None else len(file_permission.encode('utf-8')) > 8 * 1024
80+
file_permission_size_too_big = False if file_permission is None \
81+
else len(str(file_permission).encode('utf-8')) > 8 * 1024
8182

8283
if file_permission_size_too_big:
8384
raise ValueError(_FILE_PERMISSION_TOO_LONG)

tests/file/test_file.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def test_create_file(self):
208208

209209
def test_create_file_when_file_permission_is_too_long(self):
210210
file_name = self._get_file_reference()
211-
permission = self.get_random_bytes(9 * 1024)
211+
permission = str(self.get_random_bytes(8 * 1024 + 1))
212212
with self.assertRaises(ValueError):
213213
self.fs.create_file(self.share_name, None, file_name, 1024, file_permission=permission)
214214

@@ -224,7 +224,6 @@ def test_create_file_with_invalid_file_permission(self):
224224
def test_create_file_will_set_all_smb_properties(self):
225225
# Arrange
226226
file_name = self._get_file_reference()
227-
data = b'abc'
228227

229228
# Act
230229
self.fs.create_file(self.share_name, None, file_name, 1024)

0 commit comments

Comments
 (0)