Skip to content

Commit 0121c69

Browse files
committed
Fixed string size calculation in _validate_and_return_file_permission
1 parent 8f10e92 commit 0121c69

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

azure-storage-file/azure/storage/file/_serialization.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@ def _validate_and_format_range_headers(request, start_range, end_range, start_ra
7373

7474

7575
def _validate_and_return_file_permission(file_permission, file_permission_key, default_permission):
76-
# if file_permission and file_permission are both empty, then use the default_permission value as file permission
77-
# file_permission size should be <= 8KB, else file permission_key should be used
76+
# if file_permission and file_permission_key are both empty, then use the default_permission
77+
# value as file permission, file_permission size should be <= 8KB, else file permission_key should be used
7878
empty_file_permission = file_permission is None or len(file_permission) == 0
7979
empty_file_permission_key = file_permission_key is None or len(file_permission_key) == 0
80-
file_permission_size_too_big = getsizeof(file_permission) > 8 * 1024
80+
file_permission_size_too_big = False if file_permission is None else len(file_permission.encode('utf-8')) > 8 * 1024
8181

8282
if file_permission_size_too_big:
8383
raise ValueError(_FILE_PERMISSION_TOO_LONG)

0 commit comments

Comments
 (0)