[Storage] [STG 101] Delete Blob Conditional Access Tier #43846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
| ) | ||
|
|
||
| early = self.get_datetime_variable(variables, 'early', datetime.utcnow() - timedelta(hours=1)) | ||
| late = self.get_datetime_variable(variables, 'late', datetime.utcnow() + timedelta(hours=1)) |
Member
There was a problem hiding this comment.
This is not a great way to test this as you are setting a date time in the future. Instead, you should create the blob, record a datetime, change the blob tier, then record another datetime. Then you can test deleting the blob with the second datetime (and it should fail because the access tier has not been modified since the second datetime) and then use the first and it should be deleted. This is for if_modified, can do something opposite for if_unmodified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.