Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12910 See eng/common workflow

Copilot AI review requested due to automatic review settings November 15, 2025 00:13
@azure-sdk azure-sdk requested a review from a team as a code owner November 15, 2025 00:13
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 15, 2025
Copilot finished reviewing on behalf of azure-sdk November 15, 2025 00:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the eng/common directory with changes from azure-sdk-tools PR #12910, updating the spell-checking pipeline configuration to add a new optional feature for verifying cspell package upgrades.

Key Changes:

  • Modernized parameter definitions from inline format to YAML schema with explicit types and defaults
  • Added new EnableCspellUpgradeVerification parameter to enable optional verification of cspell package upgrades
  • Added verification logic that detects changes to eng/common/spelling/package-lock.json and runs public API spell check validation when appropriate

@azure-sdk azure-sdk force-pushed the sync-eng/common-djurek/upgrade-cspell-checks-12910 branch from 46a4d90 to 7da5434 Compare November 17, 2025 21:46
@azure-sdk azure-sdk force-pushed the sync-eng/common-djurek/upgrade-cspell-checks-12910 branch from 7da5434 to 38d90fa Compare November 18, 2025 23:40
@azure-sdk azure-sdk merged commit 5fafa16 into main Nov 19, 2025
17 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-djurek/upgrade-cspell-checks-12910 branch November 19, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants