-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Changes required for testing upgrades to cspell #53947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+43
−3
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c1cc54d
CustomCondition
danieljurek f416bcb
Add spell-check-public-api.ps1
danieljurek bf4c067
Wire up check-spelling.yml
danieljurek ac4bd63
TEST REVERT: check-spelling.yml
danieljurek 7cc3fd3
TEST REVERT: Trivial change to eng/spelling/package-lock.json
danieljurek 42917ec
Fix check-spelling.yml
danieljurek af90f09
exit 0
danieljurek c7c34a5
Add baseline
danieljurek e06fb0a
Remove extra param
danieljurek 5fc8609
Test misspelling
danieljurek 292f8ad
Revert test changes
danieljurek 16ab245
Review feedback
danieljurek b90d168
Review feedback
danieljurek b9cd319
Add support for RelativePackagePath or ServiceDirectory
danieljurek 2939995
Remove extra logging
danieljurek 47cf0e6
Use Export-API.ps1 from main
danieljurek a45d38f
Use scenario-specific spell-check-public-api.ps1
danieljurek 644b8d4
Revert check-spelling.yml
danieljurek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| param( | ||
| $ServiceDirectory = '', | ||
| $RelativePackagePath = '' | ||
| ) | ||
|
|
||
| if ($ServiceDirectory -and $RelativePackagePath) { | ||
| throw "Cannot specify both ServiceDirectory and RelativePackagePath parameters." | ||
| } | ||
|
|
||
| Set-StrictMode -Version 3.0 | ||
danieljurek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ."$PSScriptRoot/../common/scripts/common.ps1" | ||
|
|
||
| $files = @() | ||
| if ($ServiceDirectory) { | ||
| $files = Get-ChildItem -Path "$PSScriptRoot/../../sdk/$ServiceDirectory/*/api/*.cs" -File | ||
| } elseif ($RelativePackagePath) { | ||
| $files = Get-ChildItem -Path "$PSScriptRoot/../../sdk/$RelativePackagePath/api/*.cs" -File | ||
| } else { | ||
| $files = Get-ChildItem -Path "$PSScriptRoot/../../sdk/*/*/api/*.cs" -File | ||
| } | ||
|
|
||
| Write-Host "Found $($files.Count) public API surface files to spell check." | ||
| ."$PSScriptRoot/../common/spelling/Invoke-Cspell.ps1" ` | ||
| -CSpellConfigPath "./.vscode/cspell.json" ` | ||
danieljurek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| -FileList $files.FullName | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import: | ||
| - ../../.vscode/cspell.json | ||
| overrides: | ||
| - filename: '**/sdk/recoveryservices/**' | ||
| words: | ||
| - bcdr |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.