[spec-gen-sdk-runner] Move SpecGenSdkArtifactInfo to .github/shared #38816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
mikeharder
commented
Nov 14, 2025
| @@ -1,7 +1,38 @@ | |||
| /* v8 ignore start */ | |||
Member
Author
There was a problem hiding this comment.
added test coverage, so we can remove ignore
mikeharder
commented
Nov 14, 2025
.github/shared/src/sdk-types.js
Outdated
| ]); | ||
| /** | ||
| * @typedef {'azure-sdk-for-go' | 'azure-sdk-for-java' | 'azure-sdk-for-js' | 'azure-sdk-for-net' | 'azure-sdk-for-python'} SdkName | ||
| * @typedef {import("zod").infer<typeof SdkNameSchema>} SdkName |
Member
Author
There was a problem hiding this comment.
type SdkName is unchanged, but now has a schema
mikeharder
commented
Nov 14, 2025
| */ | ||
| const APIViewRequestDataSchema = z.object({ packageName: z.string(), filePath: z.string() }); | ||
| /** | ||
| * @typedef {import("zod").infer<typeof APIViewRequestDataSchema>} APIViewRequestData |
Member
Author
There was a problem hiding this comment.
type APIViewRequestData should be the same as the copy removed from eng/tools/spec-gen-sdk-runner/src/types.ts
mikeharder
commented
Nov 14, 2025
| apiViewRequestData: z.array(APIViewRequestDataSchema), | ||
| }); | ||
| /** | ||
| * @typedef {import("zod").infer<typeof SpecGenSdkArtifactInfoSchema>} SpecGenSdkArtifactInfo |
Member
Author
There was a problem hiding this comment.
type SpecGenSdkArtifactInfo should be the same as the copy removed from eng/tools/spec-gen-sdk-runner/src/types.ts
mikeharder
commented
Nov 14, 2025
mikeharder
commented
Nov 14, 2025
| head_sha = specGenSdkArtifactInfo.headSha; | ||
|
|
||
| issue_number = parseInt(specGenSdkArtifactInfo.prNumber, 10); | ||
| issue_number = parseInt(specGenSdkArtifactInfo.prNumber ?? "", 10); |
Member
Author
There was a problem hiding this comment.
parseInt() only accepts a string, not undefined. But parseInt("") returns NaN anyway, so it's a good replacement.
mikeharder
commented
Nov 14, 2025
mikeharder
commented
Nov 14, 2025
raych1
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.