-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Update configs on js side to mitigate migration breakings #38799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
@mikeharder in this case, the readme.md is defined this way, from my understanding the default tag should be package-flexibleserver-2025-08-01, which doesn't have the multiple api version issue, and the tag package-2020-01-01 should be recognized when package-singleservers option exists to satisfy the yaml expression, which shouldn't have existed in the pipeline and this package-2020-01-01 has the version uniform issue. |
We can continue the discussion in the issue I opened: Going forward, for questions like this, please open an issue (in the specs repo, or the repo of the specific tool), rather than just mentioning me in a GitHub comment. This ensures the question is tracked to completion and won't be forgotten, allows the issue to be assigned an owner, etc. Also, please try to check the code for answers to questions like this. You can search the Avocado repo for the |
|
please address avocado failure. |
Oh i noticed avocado error is approved |
@mikeharder as you are the tooling owners, I can't be 100% sure if it's a tooling issue or not without your double confirming. If you missed the thread, I could remind you in teams or start an email thread or whatever ways you prefer. You can double confirm and wait for me to create an issue for that the next day (as the time differences) if you think it's necessary and time efficient to do this way.
@mikeharder My understanding is that misrecognized the default tag isn't just a problem for MULTIPLE_API_VERSION. It's a general baseline setting for many different rules. Even this issue is reported when I review the MULTIPLE_API_VERSION issue, it has general impact on other rules as well. |
This directive is to keep the orignal parameter order and to mitigate the un-necessary breaking introduced by migration.