Skip to content

Conversation

@nasc17
Copy link
Member

@nasc17 nasc17 commented Nov 13, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

SDK call out to put it in final-state-schema
https://github.com/Azure/autorest/blob/f57d28243e499bd31bc8c50bcac116f6293f8e99/docs/extensions/readme.md#x-ms-long-running-operation

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@nasc17 nasc17 requested a review from a team as a code owner November 13, 2025 21:38
@nasc17 nasc17 added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 13, 2025
@github-actions
Copy link

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DBforPostgreSQL
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers
Java com.azure.resourcemanager:azure-resourcemanager-postgresqlflexibleserver
Python azure-mgmt-postgresqlflexibleservers

@nasc17 nasc17 changed the title Updating previously release API(20250801) with fix to final-state for long running operations and read me updates within Microsoft.DBforPostgreSQL Updating previously release API(20250801) with fix to final-state for long running operations within Microsoft.DBforPostgreSQL Nov 13, 2025
@nasc17
Copy link
Member Author

nasc17 commented Nov 13, 2025

@jliusan Please review

@nasc17
Copy link
Member Author

nasc17 commented Nov 13, 2025

@ChenxiJiang333 please review

@nasc17
Copy link
Member Author

nasc17 commented Nov 13, 2025

Swagger Avocado failure: This will have to be fix after the deprecation of older APIs that still reference single server.

@sandipsh
Copy link
Contributor

please fix the swagger avocado error, @nasc17.

@sandipsh sandipsh added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 14, 2025
@nasc17
Copy link
Member Author

nasc17 commented Nov 14, 2025

please fix the swagger avocado error, @nasc17.

@sandipsh as commented above: Swagger Avocado failure: This will have to be fix after the deprecation of older APIs that still reference single server. Has been previously approved until we can make change.

@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 14, 2025
@nasc17
Copy link
Member Author

nasc17 commented Nov 14, 2025

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@sandipsh sandipsh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 14, 2025
@sandipsh sandipsh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 14, 2025
@nasc17 nasc17 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 17, 2025
Copy link
Member

@nachoalonsoportillo nachoalonsoportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nasc17
Copy link
Member Author

nasc17 commented Nov 17, 2025

Hi @msyyc and @tadelesh please review this swagger fix. Issue found by Java SDK generation we wish to resolve

@nasc17 nasc17 merged commit 0b98b19 into Azure:main Nov 18, 2025
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. PostgreSQL PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants