-
Notifications
You must be signed in to change notification settings - Fork 466
Refactor DetermineTargetFramework to use msbuild & support multiple tfms #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mattchenderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for CI testing, but not to merge.
|
Probably work for a different PR, if at all. Determining TFM from core tools doesn't work when the function app is multi-targeted. This change is definitely an improvement, but it will have the same multi-target issue. Is there a framework parameter for Using |
Yeah I think support for multiple TFMs is a little rough at the moment. I can definitely add a check for TargetFrameworks and prompt the user for which of the TFMs they would like to use from that list. The determine TFM method comes into play for something like
But now you're like "I want docker too!"
In which case we will a) determine worker from local settings and b) determine tfm via this method We could also add support for
Yeah there is already a tfm param for func init
|
Issue describing the changes in this PR
resolves #4670
Pull request checklist
release_notes.mdAdditional information
Additional PR information