Skip to content

Conversation

@mmtr
Copy link
Member

@mmtr mmtr commented Nov 7, 2025

Fixes EDI-9

Proposed changes:

Displays a warning message when the user tries to insert a custom HTML block with restricted tags:

Screenshot 2025-11-07 at 16 07 04

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to your WP.com sandbox
  • Sandbox a WP.com Simple site
  • Go to /wp-admin/post-new.php
  • Insert a Custom HTML block
  • Make sure the warning message shows up when using any of the unsupported tags
  • Apply these changes to a WP.com Atomic site
  • Make sure the warning message never shows up, since all tags are allowed

@mmtr mmtr requested a review from a team November 7, 2025 15:13
@mmtr mmtr self-assigned this Nov 7, 2025
@mmtr mmtr added [Status] Needs Review This PR is ready for review. [Type] Feature Development of a new feature labels Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the edi-9-feature-request-supported-code-notification-message-on branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin edi-9-feature-request-supported-code-notification-message-on

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@mmtr mmtr added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Nov 7, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Nov 7, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php 0/327 (0.00%) 0.00% 1 ❤️‍🩹

1 file is newly checked for coverage.

File Coverage
projects/packages/jetpack-mu-wpcom/src/features/html-block-restricted-tags/html-block-restricted-tags.php 0/4 (0.00%) 💔

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on atomic and don't see the message. Tested on simple with block and classic theme and do see it in the customiser widget screen, the post editor and the template editor.

@mmtr mmtr merged commit 333cdbb into trunk Nov 10, 2025
66 checks passed
@mmtr mmtr deleted the edi-9-feature-request-supported-code-notification-message-on branch November 10, 2025 15:14
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [mu wpcom Feature] Html Block Restricted Tags [Package] Jetpack mu wpcom WordPress.com Features [Type] Feature Development of a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants