Skip to content

Commit ea26c70

Browse files
committed
Override file ops errors into warnings
Override file ops errors inherited form WordPressVIPMinimum into warnings
1 parent 8ef3a84 commit ea26c70

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

WordPress-VIP-Go/ruleset-test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@
296296
'Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.',
297297
],
298298
60 => [
299-
'Filesystem functions like fclose() must be used with the VIP stream. Make sure you are getting the proper stream base directory using wp_upload_dir()',
299+
'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as unlink(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/',
300300
],
301301
63 => [
302302
'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as fopen(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/',

WordPress-VIP-Go/ruleset.xml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,62 +8,77 @@
88

99
<!-- Things that may be incompatible with the VIP Go infrastructure and needs a dev to review -->
1010
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_delete">
11+
<type>warning</type>
1112
<severity>6</severity>
1213
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
1314
</rule>
1415
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_file_put_contents">
16+
<type>warning</type>
1517
<severity>6</severity>
1618
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
1719
</rule>
1820
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_flock">
21+
<type>warning</type>
1922
<severity>6</severity>
2023
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
2124
</rule>
2225
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fputcsv">
26+
<type>warning</type>
2327
<severity>6</severity>
2428
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
2529
</rule>
2630
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fputs">
31+
<type>warning</type>
2732
<severity>6</severity>
2833
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
2934
</rule>
3035
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fwrite">
36+
<type>warning</type>
3137
<severity>6</severity>
3238
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
3339
</rule>
3440
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_ftruncate">
41+
<type>warning</type>
3542
<severity>6</severity>
3643
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
3744
</rule>
3845
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_is_writable">
46+
<type>warning</type>
3947
<severity>6</severity>
4048
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
4149
</rule>
4250
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_is_writeable">
51+
<type>warning</type>
4352
<severity>6</severity>
4453
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
4554
</rule>
4655
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_link">
56+
<type>warning</type>
4757
<severity>6</severity>
4858
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
4959
</rule>
5060
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_rename">
61+
<type>warning</type>
5162
<severity>6</severity>
5263
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
5364
</rule>
5465
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_symlink">
66+
<type>warning</type>
5567
<severity>6</severity>
5668
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
5769
</rule>
5870
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_tempnam">
71+
<type>warning</type>
5972
<severity>6</severity>
6073
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
6174
</rule>
6275
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_touch">
76+
<type>warning</type>
6377
<severity>6</severity>
6478
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
6579
</rule>
6680
<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_unlink">
81+
<type>warning</type>
6782
<severity>6</severity>
6883
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
6984
</rule>

0 commit comments

Comments
 (0)