Revert changes to VIP minimum ruleset and tests

Author: hanifn

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -87,7 +87,6 @@ public function getErrorList() {
 			174 => 1,
 			175 => 1,
 			177 => 1,
-			180 => 1,
 			182 => 1,
 			183 => 1,
 			184 => 1,

WordPressVIPMinimum/ruleset-test.inc

@@ -365,24 +365,24 @@ session_status(); // Error.
 session_unregister(); // Error.
 session_unset(); // Error.
 session_write_close(); // Error.
-delete(); // Warning.
-file_put_contents( $file, $text, FILE_APPEND ); // Warning.
+delete(); // Error.
+file_put_contents( $file, $text, FILE_APPEND ); // Error.
 while ( $count > $loop ) {
-	if ( flock( $fp, LOCK_EX ) ) { // Warning.
-		fwrite( $fp, $text ); // Warning.
+	if ( flock( $fp, LOCK_EX ) ) { // Error.
+		fwrite( $fp, $text ); // Error.
 	}
 }
-fputcsv(); // Warning.
-fputs(); // Warning.
-ftruncate(); // Warning.
-is_writable(); // Warning.
-is_writeable(); // Warning.
-link(); // Warning.
-rename(); // Warning.
-symlink(); // Warning.
-tempnam(); // Warning.
-touch(); // Warning.
-unlink(); // Warning.
+fputcsv(); // Error.
+fputs(); // Error.
+ftruncate(); // Error.
+is_writable(); // Error.
+is_writeable(); // Error.
+link(); // Error.
+rename(); // Error.
+symlink(); // Error.
+tempnam(); // Error.
+touch(); // Error.
+unlink(); // Error.
 mkdir(); // Error.
 rmdir(); // Error.
 chgrp(); // Error.

WordPressVIPMinimum/ruleset-test.php

@@ -139,6 +139,21 @@
 		365 => 1,
 		366 => 1,
 		367 => 1,
+		368 => 1,
+		369 => 1,
+		371 => 1,
+		372 => 1,
+		375 => 1,
+		376 => 1,
+		377 => 1,
+		378 => 1,
+		379 => 1,
+		380 => 1,
+		381 => 1,
+		382 => 1,
+		383 => 1,
+		384 => 1,
+		385 => 1,
 		386 => 1,
 		387 => 1,
 		388 => 1,
@@ -247,21 +262,6 @@
 		288 => 1,
 		293 => 1,
 		294 => 1,
-		368 => 1,
-		369 => 1,
-		371 => 1,
-		372 => 1,
-		375 => 1,
-		376 => 1,
-		377 => 1,
-		378 => 1,
-		379 => 1,
-		380 => 1,
-		381 => 1,
-		382 => 1,
-		383 => 1,
-		384 => 1,
-		385 => 1,
 		396 => 1,
 		397 => 1,
 		398 => 1,

WordPressVIPMinimum/ruleset.xml

@@ -136,8 +136,6 @@
 		<!-- This is already covered in WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fwrite -->
 		<exclude name="WordPress.WP.AlternativeFunctions.file_system_read_fwrite"/>
 		<!-- This is already covered in WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fwrite -->
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_read_fclose"/>
-		<!-- This is already covered in WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fwrite -->
 		<exclude name="WordPress.WP.AlternativeFunctions.file_system_read_file_put_contents"/>
 	</rule>
 	<!-- VIP recommends other functions -->