Undo changes to restricted functions sniff

Author: hanifn

WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php

@@ -219,18 +219,16 @@ public function getGroups() {
 					'session_write_close',
 				],
 			],
-			// @link VIP Go: https://vip.wordpress.com/documentation/using-wp_filesystem-instead-of-direct-file-access-functions/
 			'file_ops' => [
-				'type'      => 'warning',
-				'message'   => 'Filesystem functions like %s() must be used with the VIP stream. Make sure you are getting the proper stream base directory using wp_upload_dir()',
+				'type'      => 'error',
+				'message'   => 'Filesystem writes are forbidden, please do not use %s().',
 				'functions' => [
 					'delete',
 					'file_put_contents',
 					'flock',
 					'fputcsv',
 					'fputs',
 					'fwrite',
-					'fclose',
 					'ftruncate',
 					'is_writable',
 					'is_writeable',

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -83,6 +83,23 @@ public function getErrorList() {
 			164 => 1,
 			165 => 1,
 			166 => 1,
+			168 => 1,
+			174 => 1,
+			175 => 1,
+			177 => 1,
+			180 => 1,
+			182 => 1,
+			183 => 1,
+			184 => 1,
+			185 => 1,
+			186 => 1,
+			187 => 1,
+			188 => 1,
+			189 => 1,
+			190 => 1,
+			191 => 1,
+			192 => 1,
+			193 => 1,
 			194 => 1,
 			195 => 1,
 			196 => 1,
@@ -116,23 +133,6 @@ public function getWarningList() {
 			137 => 1,
 			138 => 1,
 			139 => 1,
-			168 => 1,
-			174 => 1,
-			175 => 1,
-			177 => 1,
-			180 => 1,
-			182 => 1,
-			183 => 1,
-			184 => 1,
-			185 => 1,
-			186 => 1,
-			187 => 1,
-			188 => 1,
-			189 => 1,
-			190 => 1,
-			191 => 1,
-			192 => 1,
-			193 => 1,
 			208 => 1,
 		];
 	}