Skip to content

Commit 0fb90dc

Browse files
authored
Merge pull request #607 from Automattic/rebecca/cleanup_605
WordPress.Security.NonceVerification.NoNonceVerification: Remove outdated reference from WordPress-VIP-Go ruleset and let inheritance from parent
2 parents 4e334c1 + 77e07fe commit 0fb90dc

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

WordPress-VIP-Go/ruleset-test.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ $external_resource = file_get_contents( $test ); // Warning + Message.
6767
$file_content = file_get_contents( 'my-file.svg' ); // Ok.
6868
wpcom_vip_file_get_contents( $bar ); // Ok.
6969

70-
// WordPress.Security.NonceVerification.NoNonceVerification
70+
// WordPress.Security.NonceVerification (inherited from parent)
7171
function bar_foo() {
7272
if ( ! isset( $_POST['test'] ) ) { // Error.
7373
return;

WordPress-VIP-Go/ruleset.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,6 @@
121121

122122

123123
<!-- Warnings and other things -->
124-
<rule ref="WordPress.Security.NonceVerification.NoNonceVerification">
125-
<!-- Needs a manual check -->
126-
<type>warning</type>
127-
<severity>10</severity>
128-
</rule>
129124
<rule ref="WordPress.Security.ValidatedSanitizedInput.InputNotSanitized">
130125
<!-- Needs a manual check -->
131126
<type>warning</type>

0 commit comments

Comments
 (0)