Merge pull request #618 from Automattic/rebecca/cache_constraints_messaging

Remove Batcache references in messaging

Author: rebeccahum

WordPress-VIP-Go/ruleset.xml

@@ -93,19 +93,15 @@
 		<message>Hiding of admin bar is highly discouraged for user roles of "administrator" and "vip_support" -- if these roles are already excluded, this warning can be ignored.</message>
 	</rule>
 	<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.cookies_setcookie">
-		<type>error</type>
 		<severity>6</severity>
-		<message>Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.</message>
 	</rule>
 	<rule ref="WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE">
 		<type>error</type>
 		<severity>6</severity>
-		<message>Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.</message>
 	</rule>
 	<rule ref="WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___SERVER__HTTP_USER_AGENT__">
 		<type>error</type>
 		<severity>6</severity>
-		<message>Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.</message>
 	</rule>
 
 

WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php

@@ -310,8 +310,8 @@ public function getGroups() {
 			// @link WordPress.com: https://lobby.vip.wordpress.com/wordpress-com-documentation/code-review-what-we-look-for/#custom-roles
 			// @link VIP Go: https://wpvip.com/documentation/vip-go/code-review-blockers-warnings-notices/#cache-constraints
 			'cookies' => [
-				'type'      => 'warning',
-				'message'   => 'Due to using Batcache, server side based client related logic will not work, use JS instead.',
+				'type'      => 'error',
+				'message'   => 'Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.',
 				'functions' => [
 					'setcookie',
 				],

WordPressVIPMinimum/Sniffs/Variables/RestrictedVariablesSniff.php

@@ -57,7 +57,7 @@ public function getGroups() {
 			// @link https://lobby.vip.wordpress.com/wordpress-com-documentation/code-review-what-we-look-for/#caching-constraints
 			'cache_constraints' => [
 				'type'          => 'warning',
-				'message'       => 'Due to using Batcache, server side based client related logic will not work, use JS instead.',
+				'message'       => 'Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.',
 				'variables'     => [
 					'$_COOKIE',
 				],

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc

@@ -122,7 +122,7 @@ vip_safe_wp_remote_get(); // Ok - VIP recommended version of wp_remote_get().
 wp_remote_get( $url ); // Warning.
 
 cookie( $_GET['test'] ); // Ok - similarly-named function to setcookie().
-setcookie( 'cookie[three]', 'cookiethree' ); // Warning.
+setcookie( 'cookie[three]', 'cookiethree' ); // Error.
 
 get_post( 123 ); // Ok - not using get_posts().
 wp_get_recent_post(); // Ok - similarly-named function to wp_get_recent_posts().

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -59,6 +59,7 @@ public function getErrorList() {
 			101 => 1,
 			104 => 1,
 			107 => 1,
+			125 => 1,
 			141 => 1,
 			142 => 1,
 			143 => 1,
@@ -128,7 +129,6 @@ public function getWarningList() {
 			118 => 1,
 			119 => 1,
 			122 => 1,
-			125 => 1,
 			130 => 1,
 			131 => 1,
 			132 => 1,