test: implement more tests

Author: Ark4ne

tests/Feature/User/ResourceTest.php

@@ -2,6 +2,7 @@
 
 namespace Test\Feature\User;
 
+use Ark4ne\JsonApi\Support\Config;
 use DateTimeInterface;
 use Illuminate\Http\Request;
 use Test\app\Http\Resources\CommentResource;
@@ -134,12 +135,22 @@ public function testShowMultipleFailures()
         ]]);
     }
 
+    public function testShowBasicAutoWhenIncluded()
+    {
+        Config::$autoWhenIncluded = true;
+        $user = $this->dataSeed();
+
+        $response = $this->get("user/{$user->id}");
+
+        $response->assertExactJson($this->getJsonResult($user, null, null, false));
+    }
+
     private function dataSeed()
     {
         return User::first();
     }
 
-    private function getJsonResult(User $user, ?array $attributes = null, ?array $relationships = null)
+    private function getJsonResult(User $user, ?array $attributes = null, ?array $relationships = null, bool $withIncluded = true): array
     {
         $request = new Request(array_merge(
             ($attributes !== null ? ['fields' => ['user' => implode(',', $attributes)]] : []),
@@ -156,7 +167,7 @@ private function getJsonResult(User $user, ?array $attributes = null, ?array $re
                 ], array_fill_keys($attributes ?? ['name', 'email'], true))),
                 'relationships' => [
                     'posts' => array_filter([
-                        'data' => $user->posts->map(fn(Post $post) => ['type' => 'post', 'id' => $post->id])->all(),
+                        'data' => $withIncluded ? $user->posts->map(fn(Post $post) => ['type' => 'post', 'id' => $post->id])->all() : null,
                         'links' => [
                             'self' => "https://api.example.com/user/{$user->id}/relationships/posts",
                             'related' => "https://api.example.com/user/{$user->id}/posts",
@@ -167,7 +178,7 @@ private function getJsonResult(User $user, ?array $attributes = null, ?array $re
                     ]),
                     'comments' => array_filter([
                         // when loaded only
-                        'data' => in_array('comments', $relationships ?? [])
+                        'data' => $withIncluded && in_array('comments', $relationships ?? [])
                             ? $user->comments->map(fn(Comment $comment) => [
                                 'type' => 'comment',
                                 'id' => $comment->id

tests/Unit/Descriptors/DescriptorsTraitTest.php

@@ -9,6 +9,7 @@
 use Ark4ne\JsonApi\Descriptors\Values\ValueArray;
 use Ark4ne\JsonApi\Descriptors\Values\ValueBool;
 use Ark4ne\JsonApi\Descriptors\Values\ValueDate;
+use Ark4ne\JsonApi\Descriptors\Values\ValueEnum;
 use Ark4ne\JsonApi\Descriptors\Values\ValueFloat;
 use Ark4ne\JsonApi\Descriptors\Values\ValueInteger;
 use Ark4ne\JsonApi\Descriptors\Values\ValueMixed;
@@ -31,6 +32,7 @@ public static function methods()
             'string' => [ValueString::class, 'string'],
             'date' => [ValueDate::class, 'date'],
             'array' => [ValueArray::class, 'array'],
+            'enum' => [ValueEnum::class, 'enum'],
             'mixed' => [ValueMixed::class, 'mixed'],
             'one' => [RelationOne::class, 'one', JsonApiResource::class],
             'many' => [RelationMany::class, 'many', JsonApiCollection::class],

tests/Unit/Descriptors/ValueTest.php

@@ -188,6 +188,24 @@ public function testWhenFilled(&$model)
         );
     }
 
+    /**
+     * @dataProvider models
+     */
+    public function testUnless(&$model)
+    {
+        data_set($model, 'attr', 'abc');
+
+        $unless = (object)['value' => true];
+
+        $this->throughRetrieverTest(
+            $model,
+            fn(Value $value) => $value->unless(fn() => $unless->value)->valueFor(new Request, $model, 'attr'),
+            fn() => $unless->value = false,
+            fn(Value $value) => $value->valueFor(new Request, $model, 'attr'),
+            'abc'
+        );
+    }
+
     /**
      * @dataProvider models
      */
@@ -240,10 +258,10 @@ private function throughRetrieverTest(&$model, \Closure $missing, \Closure $upda
         $this->assertInstanceOf(MissingValue::class, $missing($valueClosureRetriever));
 
         $update();
-
-        $this->assertEquals($expected, $check($valueWithRetriever));
-        $this->assertEquals($expected, $check($valueNoRetriever));
-        $this->assertEquals($expected, $check($valueClosureRetriever));
+        $actual = $check($valueWithRetriever);
+        $this->assertEquals($expected, $actual);
+        $this->assertEquals($expected, $actual = $check($valueNoRetriever));
+        $this->assertEquals($expected, $actual = $check($valueClosureRetriever));
     }
 }
 

tests/Unit/Resources/Concerns/ConditionallyLoadsAttributesTest.php

@@ -137,4 +137,14 @@ public function testWhenHas()
         $this->assertEquals(new MissingValue, Reflect::invoke($resource, 'whenHas', 'b', 'abc'));
         $this->assertEquals('missing', Reflect::invoke($resource, 'whenHas', 'b', 'abc', 'missing'));
     }
+
+    public function testUnless()
+    {
+        $resource = new class([]) extends JsonResource {
+            use ConditionallyLoadsAttributes;
+        };
+
+        $this->assertEquals(new MissingValue, Reflect::invoke($resource, 'unless', true, 'a'));
+        $this->assertEquals('a', Reflect::invoke($resource, 'unless', false, 'a'));
+    }
 }