test: implement more tests

Author: Ark4ne

config/jsonapi.php

@@ -41,7 +41,6 @@
         */
         'precision' => null,
 
-        'when-has' => false,
         /*
         |--------------------------------------------------------------------------
         | When Has
@@ -68,6 +67,7 @@
         |                ->whenHas('last_name')
         |                ->whenHas('first_name'),
         */
+        'when-has' => false,
     ],
 
     'relationship' => [

tests/Feature/FeatureTestCase.php

@@ -13,6 +13,11 @@ abstract class FeatureTestCase extends TestCase
 {
     use RefreshDatabase;
 
+    protected function defineEnvironment($app)
+    {
+        $app['config']['jsonapi'] = include __DIR__ . '/../app/jsonapi.php';
+    }
+
     protected function defineRoutes($router)
     {
         include __DIR__ . '/../app/routes.php';

tests/Unit/Resources/Concerns/ConditionallyLoadsAttributesTest.php

@@ -7,6 +7,7 @@
 use Ark4ne\JsonApi\Descriptors\Values\ValueMixed;
 use Ark4ne\JsonApi\Resources\Concerns\ConditionallyLoadsAttributes;
 use Ark4ne\JsonApi\Resources\Relationship;
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 use Illuminate\Http\Resources\MergeValue;
@@ -114,4 +115,26 @@ public function testApplyWhen()
             'missing.5' => RelationMissing::fromRelationship((new Relationship(UserResource::class, fn() => null))),
         ]), $actual);
     }
+
+    public function testWhenHas()
+    {
+        $resource = new class(['a' => 1]) extends JsonResource {
+            use ConditionallyLoadsAttributes;
+        };
+        $this->assertEquals(1, Reflect::invoke($resource, 'whenHas', 'a'));
+        $this->assertEquals('abc', Reflect::invoke($resource, 'whenHas', 'a', 'abc'));
+        $this->assertEquals(new MissingValue, Reflect::invoke($resource, 'whenHas', 'b'));
+        $this->assertEquals(new MissingValue, Reflect::invoke($resource, 'whenHas', 'b', 'missing'));
+        $this->assertEquals('missing', Reflect::invoke($resource, 'whenHas', 'b', 'abc', 'missing'));
+
+        $resource = new class((object)['a' => 1]) extends JsonResource {
+            use ConditionallyLoadsAttributes;
+        };
+
+        $this->assertEquals(1, Reflect::invoke($resource, 'whenHas', 'a'));
+        $this->assertEquals('abc', Reflect::invoke($resource, 'whenHas', 'a', 'abc'));
+        $this->assertEquals(new MissingValue, Reflect::invoke($resource, 'whenHas', 'b'));
+        $this->assertEquals(new MissingValue, Reflect::invoke($resource, 'whenHas', 'b', 'abc'));
+        $this->assertEquals('missing', Reflect::invoke($resource, 'whenHas', 'b', 'abc', 'missing'));
+    }
 }

tests/Unit/Support/ValuesTest.php

@@ -106,4 +106,44 @@ public function isMissing()
 
         $this->assertEquals(true, Values::isMissing(new JsonResource(new MissingValue())));
     }
+
+
+    /**
+     * Return a list of data to test hasAttribute method
+     */
+    public function dataAttribute()
+    {
+        return [
+            'array' => [['a' => 1], 'a', true, 1],
+            'array.empty' => [[], 'a', false, null],
+            'array.fail' => [['a' => 1], 'b', false, null],
+            'object' => [(object)['a' => 1], 'a', true, 1],
+            'object.empty' => [(object)[], 'a', false, null],
+            'object.fail' => [(object)['a' => 1], 'b', false, null],
+            'model' => [new class(['a' => 1]) extends \Illuminate\Database\Eloquent\Model {
+                protected $fillable = ['a'];
+            }, 'a', true, 1],
+            'model.empty' => [new class() extends \Illuminate\Database\Eloquent\Model {
+            }, 'a', false, null],
+            'model.fail' => [new class(['a' => 1]) extends \Illuminate\Database\Eloquent\Model {
+                protected $fillable = ['a'];
+            }, 'b', false, null],
+        ];
+    }
+
+    /**
+     * @dataProvider dataAttribute
+     */
+    public function testHasAttribute($data, $attribute, $expected)
+    {
+        $this->assertEquals($expected, Values::hasAttribute($data, $attribute));
+    }
+
+    /**
+     * @dataProvider dataAttribute
+     */
+    public function testGetAttribute($data, $attribute, $has, $expected)
+    {
+        $this->assertEquals($expected, Values::getAttribute($data, $attribute));
+    }
 }

tests/app/jsonapi.php

@@ -0,0 +1,7 @@
+<?php
+
+$config = include __DIR__ . '/../../config/jsonapi.php';
+
+$config['describer']['when-has'] = true;
+
+return $config;