Further work to address copy assignment memory leak.

Author: jgfoster

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 - Change 266 files from CRLF to LF.
+- Apply "rule of three" to Client copy constructor and copy assignment operator
 
 ### Deprecated
 

cpp/arduino/Client.h

@@ -13,16 +13,18 @@ class Client : public Stream {
   }
   Client(const Client &client) { // copy constructor
     if (this != &client) {       // not a self-assignment
-      if (mGodmodeDataIn) {      // replace what we previously had
-        delete mGodmodeDataIn;   // get rid of previous value
+      if (mGodmodeDataIn &&
+          client.mGodmodeDataIn) { // replace what we previously had
+        delete mGodmodeDataIn;     // get rid of previous value
         mGodmodeDataIn = new String(client.mGodmodeDataIn->c_str());
       }
     }
   }
   Client &operator=(const Client &client) { // copy assignment operator
     if (this != &client) {                  // not a self-assignment
-      if (mGodmodeDataIn) {                 // replace what we previously had
-        delete mGodmodeDataIn;              // get rid of previous value
+      if (mGodmodeDataIn &&
+          client.mGodmodeDataIn) { // replace what we previously had
+        delete mGodmodeDataIn;     // get rid of previous value
         mGodmodeDataIn = new String(client.mGodmodeDataIn->c_str());
       }
     }