Fix memory leak in copy constructor and copy assignment operator.

Author: jgfoster

cpp/arduino/Client.h

@@ -1,7 +1,7 @@
 #pragma once
 
-#include <Stream.h>
 #include <IPAddress.h>
+#include <Stream.h>
 
 class Client : public Stream {
 public:
@@ -11,16 +11,20 @@ class Client : public Stream {
       mGodmodeDataIn = new String;
     }
   }
-  Client(const Client &client) {
-    // copy constructor 
-    if (mGodmodeDataIn) {
-      mGodmodeDataIn = new String(mGodmodeDataIn->c_str());
+  Client(const Client &client) { // copy constructor
+    if (this != &client) {       // not a self-assignment
+      if (mGodmodeDataIn) {      // replace what we previously had
+        delete mGodmodeDataIn;   // get rid of previous value
+        mGodmodeDataIn = new String(client.mGodmodeDataIn->c_str());
+      }
     }
   }
-  Client & operator=(const Client &client) {
-    // copy assignment operator 
-    if (mGodmodeDataIn) {
-      mGodmodeDataIn = new String(mGodmodeDataIn->c_str());
+  Client &operator=(const Client &client) { // copy assignment operator
+    if (this != &client) {                  // not a self-assignment
+      if (mGodmodeDataIn) {                 // replace what we previously had
+        delete mGodmodeDataIn;              // get rid of previous value
+        mGodmodeDataIn = new String(client.mGodmodeDataIn->c_str());
+      }
     }
     return *this;
   }