Skip to content

Fix font scaling and update bookmark dialog layout #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 131-update-tb-guide-android-app-ui-with-new-figma-design
Choose a base branch
from
Open

Fix font scaling and update bookmark dialog layout #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/src/main/java/org/apphatchery/gatbreferenceguide/app/App.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.apphatchery.gatbreferenceguide.app

import android.app.Application
import android.content.Context
import android.content.res.Configuration
import androidx.appcompat.app.AppCompatDelegate
import androidx.preference.PreferenceManager
import com.google.firebase.FirebaseApp
Expand All @@ -11,6 +13,12 @@ import sdk.pendo.io.Pendo
@HiltAndroidApp
class App : Application() {

override fun attachBaseContext(base: Context) {
val configuration = Configuration(base.resources.configuration)
configuration.fontScale = 1.0f
super.attachBaseContext(base.createConfigurationContext(configuration))
}

override fun onCreate() {
super.onCreate()

Expand Down
8 changes: 8 additions & 0 deletions app/src/main/java/org/apphatchery/gatbreferenceguide/ui/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package org.apphatchery.gatbreferenceguide.ui

import android.content.Context
import android.content.SharedPreferences
import android.content.pm.ActivityInfo
import android.content.res.Configuration
import android.os.Bundle
import android.util.Log
import android.view.View
Expand Down Expand Up @@ -57,6 +59,12 @@ class MainActivity : AppCompatActivity(), ActionBarController {
// Search view properties - will be initialized when needed
private var searchViewContainer: View? = null

override fun attachBaseContext(newBase: Context) {
val configuration = Configuration(newBase.resources.configuration)
configuration.fontScale = 1.0f
super.attachBaseContext(newBase.createConfigurationContext(configuration))
}

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
binding = ActivityMainBinding.inflate(layoutInflater)
Expand Down
20 changes: 6 additions & 14 deletions app/src/main/res/layout/dialog_bookmark_success.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,17 @@
android:layout_gravity="center"
android:background="@drawable/bookmark_popup_background">

<ScrollView
<TextView
android:id="@+id/bookmarked_text"
android:layout_width="219dp"
android:layout_height="82dp"
android:layout_centerHorizontal="true"
android:layout_alignParentTop="true"
android:layout_marginTop="35dp"
android:fillViewport="true"
android:scrollbars="vertical">

<TextView
android:id="@+id/bookmarked_text"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="82dp"
android:text="@string/bookmarked_message"
android:textAppearance="@style/BookmarkedTextStyle"
android:textColor="?attr/colorTextBlackWhite" />

</ScrollView>
android:text="@string/bookmarked_message"
android:textAppearance="@style/BookmarkedTextStyle"
android:textColor="?attr/colorTextBlackWhite"
android:autoSizeTextType="none" />

<androidx.appcompat.widget.AppCompatButton
android:id="@+id/visit_button"
Expand Down