Update setup.md - adding playServicesLocationVersion #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup instructions suggest adding
googlePlayServicesVersion,playServicesVersionorplayServicesLocationVersionto theandroid/build.gradlefile.Only using the last one
playServicesLocationVersionworks. The other 2 throw dependency errors.Summary
android/build.gradlefile.googlePlayServicesVersionorplayServicesVersionthrows an error while usingplayServicesLocationVersionworks.#398
Test Plan
I tried using
googlePlayServicesVersionand usingplayServicesVersion. In both scenarios, building the app (by executingnpx react-native run-android) throws an error regarding dependencies. I usedplayServicesLocationVersion. The app was built successfully, and the current location was picked correctly.