-
Notifications
You must be signed in to change notification settings - Fork 146
BalancePlatform TransferLimits: update order of path params for deletePendingTransferLimit and getSpecificTransferLimit #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in the OpenAPI specification for the BalancePlatform TransferLimits service, specifically concerning the order of path parameters for certain API endpoints. The changes involve regenerating the affected Java service classes to correctly reflect the updated OpenAPI definition, ensuring that methods like Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the BalancePlatform TransferLimits service classes and tests to reflect a change in the OpenAPI specification, specifically correcting the order of path parameters for deletePendingTransferLimit and getSpecificTransferLimit methods. The changes are mostly generated and look correct, including updates to method signatures, Javadoc, and internal logic. The corresponding test files are also updated to match these changes. I've pointed out a few minor formatting inconsistencies in one of the test files that should be addressed for code style consistency.
PR to regenerate BalancePlatform
TransferLimitsservices: the OpenAPI file has been updated to correct the order the path parameters, this PR (re)generates the service classes and corrects the tests.