feat: add last transfer heuristic for transactions which fail to parse #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barskhianfannie
force-pushed
the
main
branch
2 times, most recently
from
85599bb to
502eade
Compare
barskhianfannie
force-pushed
the
main
branch
from
502eade to
20439b5
Compare
barskhianfannie
changed the title
barskhianfannie
changed the title
hzhu
reviewed
Nov 30, 2025
src/tests/index.test.ts
Outdated
| address: "0x4200000000000000000000000000000000000006", | ||
| }, | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Can you add a new line here? 🙏
Suggested change
| }); | |
| }); | |
hzhu
previously approved these changes
Nov 30, 2025
Member
|
Thanks for the PR! Appreciate the description, and tying the PR to an issue. |
barskhianfannie
changed the title
barskhianfannie
commented
Dec 3, 2025
barskhianfannie
commented
Dec 3, 2025
Comment on lines
+117
to
+150
| if (to?.toLowerCase() === FORWARDING_MULTICALL_ADDRESS.toLowerCase()) { | ||
| const { args: multicallArgs } = decodeFunctionData({ | ||
| abi: FORWARDING_MULTICALL_ABI, | ||
| data: transaction.input, | ||
| }); | ||
|
|
||
| if (multicallArgs && Array.isArray(multicallArgs) && multicallArgs[0] && Array.isArray(multicallArgs[0])) { | ||
| const { args: settlerArgs } = decodeFunctionData({ | ||
| abi: SETTLER_META_TXN_ABI, | ||
| data: multicallArgs[0][1]?.data, | ||
| }); | ||
|
|
||
| const recipient = | ||
| settlerArgs[0].recipient.toLowerCase() as Address; | ||
|
|
||
| const msgSender = settlerArgs[3]; | ||
|
|
||
| const nativeAmountToTaker = calculateNativeTransfer(trace, { | ||
| recipient, | ||
| }); | ||
|
|
||
| if (nativeAmountToTaker === "0") { | ||
| [output] = logs.filter( | ||
| (log) => log.to.toLowerCase() === msgSender.toLowerCase() | ||
| ); | ||
| } else { | ||
| output = { | ||
| symbol: NATIVE_SYMBOL_BY_CHAIN_ID[chainId], | ||
| amount: nativeAmountToTaker, | ||
| address: NATIVE_TOKEN_ADDRESS, | ||
| }; | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
MultiCall3 will no longer be used and we can instead rely on the forwarding multi call address and abi @ this step of txn parsing. I decided to leave the previous logic related to Multicall3 to maintain backwards compatibility.
cc: @duncancmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing parser fails in two example swaps:
0x7eea91c5c715ef4bb1e39ddf4c7832113693e87c18392740353d5ae669406a46Etherscan0xdee6f4fea0250f297ed9663c4ca4479e8a253c62e16faa60759e25832cd1f34fOpScanThis is occurring because we are relying on
MultiCall3to parse txns when we should instead rely on Forwarding Multi Call.Resolves Issue #94
Solution
Apply the necessary logic for Forward Multi Call support.
Changes
src/index.ts: Added logic for txn decoding when thetoaddress equals the Forwarding Multi Call address (0x00000000000000CF9E3c5A26621af382fA17f24f),src/tests/index.test.ts: Added tests for the failing txnssrc/tests/constants.tsx: AddedFORWARDING_MULTICALL_ADDRESSandFORWARDING_MULTICALL_ABITesting
Ensure all tests are passing locally.
Additional Changes
.env.exampleregarding the various environment variables needed to successfully run all tests.