refactor: Replace 'PRIVATE' with 'DIRECT'.

Author: Ajnus

tests/ui/test_ui_tools.py

@@ -971,8 +971,8 @@ def test_keypress_NEXT_UNREAD_PM_no_pm(
 
         assert return_value == key
 
-    @pytest.mark.parametrize("key", keys_for_command("PRIVATE_MESSAGE"))
-    def test_keypress_PRIVATE_MESSAGE(self, mid_col_view, mocker, key, widget_size):
+    @pytest.mark.parametrize("key", keys_for_command("DIRECT_MESSAGE"))
+    def test_keypress_DIRECT_MESSAGE(self, mid_col_view, mocker, key, widget_size):
         size = widget_size(mid_col_view)
         mocker.patch(MIDCOLVIEW + ".focus_position")
         mid_col_view.model.get_next_unread_pm.return_value = None

zulipterminal/config/keys.py

@@ -137,7 +137,7 @@ class KeyBinding(TypedDict):
         'help_text': 'New message to a stream',
         'key_category': 'open_compose',
     },
-    'PRIVATE_MESSAGE': {
+    'DIRECT_MESSAGE': {
         'keys': ['x'],
         'help_text': 'New message to a person or group of people',
         'key_category': 'open_compose',

zulipterminal/helper.py

@@ -381,7 +381,7 @@ def index_messages(messages: List[Message], model: Any, index: Index) -> Index:
         'messages': {
             # all the messages mapped to their id
             # for easy retrieval of message from id
-            45645: {  # PRIVATE
+            45645: {  # DIRECT
                 'id': 4290,
                 'timestamp': 1521817473,
                 'content': 'Hi @**Cordelia Lear**',

zulipterminal/ui.py

@@ -262,7 +262,7 @@ def keypress(self, size: urwid_Box, key: str) -> Optional[str]:
             or is_command_key("NEXT_UNREAD_TOPIC", key)
             or is_command_key("NEXT_UNREAD_PM", key)
             or is_command_key("STREAM_MESSAGE", key)
-            or is_command_key("PRIVATE_MESSAGE", key)
+            or is_command_key("DIRECT_MESSAGE", key)
         ):
             self.show_left_panel(visible=False)
             self.show_right_panel(visible=False)

zulipterminal/ui_tools/views.py

@@ -639,7 +639,7 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
                 recipient_emails=[email],
                 contextual_message_id=dm,
             )
-        elif is_command_key("PRIVATE_MESSAGE", key):
+        elif is_command_key("DIRECT_MESSAGE", key):
             # Create new PM message
             self.footer.private_box_view()
             self.set_focus("footer")