scripts/debug: Fix debugging helper tool checks.

Author: sundanc

setup.py

@@ -94,7 +94,8 @@ def long_description():
         "console_scripts": [
             "zulip-term = zulipterminal.cli.run:main",
             "zulip-term-check-symbols = zulipterminal.scripts.render_symbols:main",
-            "zulip-term-debug = zulipterminal.scripts.debug_helper:main",  # Added debug helper
+            # Added debug helper with proper path
+            "zulip-term-debug = zulipterminal.scripts.debug_helper:main",
         ],
     },
     extras_require={

zulipterminal/scripts/debug_helper.py

@@ -13,18 +13,18 @@
 import re
 import subprocess
 import json
-from pathlib import Path
+from typing import Optional, Any
 
 
-def analyze_debug_log(log_file="debug.log"):
+def analyze_debug_log(log_file: str = "debug.log") -> None:
     """
     Analyze a debug log file for common issues.
     """
     if not os.path.exists(log_file):
-        print(f"Error: Log file '{log_file}' not found")
+        print(f"Error: Log file '{log_file}' not found")  # noqa: T201
         return
 
-    print(f"Analyzing {log_file}...")
+    print(f"Analyzing {log_file}...")  # noqa: T201
     with open(log_file, 'r') as f:
         content = f.read()
 
@@ -46,14 +46,14 @@ def analyze_debug_log(log_file="debug.log"):
                 line_end = len(content)
 
             line = content[line_start:line_end].strip()
-            print(f"Potential issue found: {line}")
+            print(f"Potential issue found: {line}")  # noqa: T201
             errors_found = True
 
     if not errors_found:
-        print("No obvious errors found in the log file.")
+        print("No obvious errors found in the log file.")  # noqa: T201
 
 
-def test_connectivity(server_url=None):
+def test_connectivity(server_url: Optional[str] = None) -> None:
     """
     Test connectivity to a Zulip server.
     """
@@ -68,41 +68,41 @@ def test_connectivity(server_url=None):
                         break
 
     if not server_url:
-        print("Error: No server URL provided and couldn't find one in ~/.zuliprc")
+        print("Error: No server URL provided and couldn't find one in ~/.zuliprc")  # noqa: T201
         return
 
-    print(f"Testing connectivity to {server_url}...")
+    print(f"Testing connectivity to {server_url}...")  # noqa: T201
     try:
         import requests
         response = requests.get(f"{server_url}/api/v1/server_settings")
         if response.status_code == 200:
-            print(f"Successfully connected to {server_url}")
+            print(f"Successfully connected to {server_url}")  # noqa: T201
             try:
                 settings = response.json()
-                print(f"Server version: {settings.get('zulip_version', 'unknown')}")
+                print(f"Server version: {settings.get('zulip_version', 'unknown')}")  # noqa: T201
             except json.JSONDecodeError:
-                print("Received response, but couldn't parse as JSON")
+                print("Received response, but couldn't parse as JSON")  # noqa: T201
         else:
-            print(f"Failed to connect: HTTP status {response.status_code}")
+            print(f"Failed to connect: HTTP status {response.status_code}")  # noqa: T201
     except Exception as e:
-        print(f"Connection error: {e}")
+        print(f"Connection error: {e}")  # noqa: T201
 
 
-def check_terminal_capabilities():
+def check_terminal_capabilities() -> None:
     """
     Check for terminal capabilities that might affect Zulip Terminal.
     """
-    print("Checking terminal capabilities...")
+    print("Checking terminal capabilities...")  # noqa: T201
 
     # Check for color support
     colors = os.environ.get('TERM', 'unknown')
-    print(f"TERM environment: {colors}")
+    print(f"TERM environment: {colors}")  # noqa: T201
 
     if 'COLORTERM' in os.environ:
-        print(f"COLORTERM: {os.environ['COLORTERM']}")
+        print(f"COLORTERM: {os.environ['COLORTERM']}")  # noqa: T201
 
     # Check for Unicode support
-    print("\nTesting Unicode rendering capabilities:")
+    print("\nTesting Unicode rendering capabilities:")  # noqa: T201
     test_chars = [
         ("Basic symbols", "▶ ◀ ✓ ✗"),
         ("Emoji (simple)", "😀 🙂 👍"),
@@ -111,19 +111,22 @@ def check_terminal_capabilities():
     ]
 
     for name, chars in test_chars:
-        print(f"  {name}: {chars}")
+        print(f"  {name}: {chars}")  # noqa: T201
 
     # Check for urwid compatibility
     try:
-        import urwid
-        print("\nUrwid detected. Running basic urwid test...")
+        import urwid  # noqa: F401
+        print("\nUrwid detected. Running basic urwid test...")  # noqa: T201
         # This doesn't actually run a visual test - just checks if urwid can be imported
-        print("Urwid import successful")
+        print("Urwid import successful")  # noqa: T201
     except ImportError:
-        print("Urwid not found. This may indicate installation issues.")
+        print("Urwid not found. This may indicate installation issues.")  # noqa: T201
 
 
-def main():
+def main() -> None:
+    """
+    Main entry point for the debugging helper.
+    """
     parser = argparse.ArgumentParser(description="Zulip Terminal Debugging Helper")
     subparsers = parser.add_subparsers(dest="command", help="Command to run")
 
@@ -136,7 +139,7 @@ def main():
     conn_parser.add_argument("--server", help="Server URL (e.g., https://chat.zulip.org)")
 
     # Terminal test
-    term_parser = subparsers.add_parser("terminal", help="Check terminal capabilities")
+    subparsers.add_parser("terminal", help="Check terminal capabilities")
 
     # Run zulip-term with debug
     run_parser = subparsers.add_parser("run", help="Run zulip-term with debugging")
@@ -154,7 +157,7 @@ def main():
         cmd = ["zulip-term", "-d"]
         if args.profile:
             cmd.append("--profile")
-        print(f"Running: {' '.join(cmd)}")
+        print(f"Running: {' '.join(cmd)}")  # noqa: T201
         subprocess.run(cmd)
     else:
         parser.print_help()