scripts: Use parameter format in debug_helper.py logging statements

Author: sundanc

zulipterminal/scripts/debug_helper.py

@@ -16,6 +16,7 @@
 import subprocess
 from typing import Optional
 
+
 # Configure logging
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
@@ -26,10 +27,10 @@ def analyze_debug_log(log_file: str = "debug.log") -> None:
     Analyze a debug log file for common issues.
     """
     if not os.path.exists(log_file):
-        logger.error(f"Log file '{log_file}' not found")
+        logger.error("Log file '%s' not found", log_file)
         return
 
-    logger.info(f"Analyzing {log_file}...")
+    logger.info("Analyzing %s...", log_file)
     with open(log_file, "r") as f:
         content = f.read()
 
@@ -46,7 +47,7 @@ def analyze_debug_log(log_file: str = "debug.log") -> None:
                 line_end = len(content)
 
             line = content[line_start:line_end].strip()
-            logger.warning(f"Potential issue found: {line}")
+            logger.warning("Potential issue found: %s", line)
             errors_found = True
 
     if not errors_found:
@@ -71,22 +72,24 @@ def test_connectivity(server_url: Optional[str] = None) -> None:
         logger.error("No server URL provided and couldn't find one in ~/.zuliprc")
         return
 
-    logger.info(f"Testing connectivity to {server_url}...")
+    logger.info("Testing connectivity to %s...", server_url)
     try:
         import requests
 
         response = requests.get(f"{server_url}/api/v1/server_settings")
         if response.status_code == 200:
-            logger.info(f"Successfully connected to {server_url}")
+            logger.info("Successfully connected to %s", server_url)
             try:
                 settings = response.json()
-                logger.info(f"Server version: {settings.get('zulip_version', 'unknown')}")
+                logger.info(
+                    "Server version: %s", settings.get("zulip_version", "unknown")
+                )
             except json.JSONDecodeError:
                 logger.error("Received response, but couldn't parse as JSON")
         else:
-            logger.error(f"Failed to connect: HTTP status {response.status_code}")
+            logger.error("Failed to connect: HTTP status %s", response.status_code)
     except Exception as e:
-        logger.error(f"Connection error: {e}")
+        logger.error("Connection error: %s", e)
 
 
 def check_terminal_capabilities() -> None:
@@ -97,10 +100,10 @@ def check_terminal_capabilities() -> None:
 
     # Check for color support
     colors = os.environ.get("TERM", "unknown")
-    logger.info(f"TERM environment: {colors}")
+    logger.info("TERM environment: %s", colors)
 
     if "COLORTERM" in os.environ:
-        logger.info(f"COLORTERM: {os.environ['COLORTERM']}")
+        logger.info("COLORTERM: %s", os.environ["COLORTERM"])
 
     # Check for Unicode support
     logger.info("Testing Unicode rendering capabilities:")
@@ -112,17 +115,7 @@ def check_terminal_capabilities() -> None:
     ]
 
     for name, chars in test_chars:
-        logger.info(f"  {name}: {chars}")
-
-    # Check for urwid compatibility
-    try:
-        import urwid
-
-        logger.info("Urwid detected. Running basic urwid test...")
-        # This doesn't actually run a visual test - just checks if urwid can be imported
-        logger.info("Urwid import successful")
-    except ImportError:
-        logger.warning("Urwid not found. This may indicate installation issues.")
+        logger.info("  %s: %s", name, chars)
 
 
 def main() -> None:
@@ -138,7 +131,9 @@ def main() -> None:
 
     # Connectivity test
     conn_parser = subparsers.add_parser("connect", help="Test connectivity")
-    conn_parser.add_argument("--server", help="Server URL (e.g., https://chat.zulip.org)")
+    conn_parser.add_argument(
+        "--server", help="Server URL (e.g., https://chat.zulip.org)"
+    )
 
     # Terminal test
     subparsers.add_parser("terminal", help="Check terminal capabilities")
@@ -159,8 +154,8 @@ def main() -> None:
         cmd = ["zulip-term", "-d"]
         if args.profile:
             cmd.append("--profile")
-        logger.info(f"Running: {' '.join(cmd)}")
-        subprocess.run(cmd)
+        logger.info("Running: %s", " ".join(cmd))
+        subprocess.run(cmd, check=False)
     else:
         parser.print_help()