scripts/debug: Fix debugging helper tool checks.

Author: sundanc

zulipterminal/scripts/debug_helper.py

@@ -13,18 +13,22 @@
 import os
 import re
 import subprocess
+import logging  # Added logging
 from typing import Optional
 
+# Configure logging
+logging.basicConfig(level=logging.INFO)
+logger = logging.getLogger(__name__)
 
 def analyze_debug_log(log_file: str = "debug.log") -> None:
     """
     Analyze a debug log file for common issues.
     """
     if not os.path.exists(log_file):
-        print(f"Error: Log file '{log_file}' not found")  # noqa: T201
+        logger.error(f"Log file '{log_file}' not found")
         return
 
-    print(f"Analyzing {log_file}...")  # noqa: T201
+    logger.info(f"Analyzing {log_file}...")
     with open(log_file, "r") as f:
         content = f.read()
 
@@ -41,11 +45,11 @@ def analyze_debug_log(log_file: str = "debug.log") -> None:
                 line_end = len(content)
 
             line = content[line_start:line_end].strip()
-            print(f"Potential issue found: {line}")  # noqa: T201
+            logger.warning(f"Potential issue found: {line}")
             errors_found = True
 
     if not errors_found:
-        print("No obvious errors found in the log file.")  # noqa: T201
+        logger.info("No obvious errors found in the log file.")
 
 
 def test_connectivity(server_url: Optional[str] = None) -> None:
@@ -63,48 +67,46 @@ def test_connectivity(server_url: Optional[str] = None) -> None:
                         break
 
     if not server_url:
-        print(
-            "Error: No server URL provided and couldn't find one in ~/.zuliprc"
-        )  # noqa: T201
+        logger.error(
+            "No server URL provided and couldn't find one in ~/.zuliprc"
+        )
         return
 
-    print(f"Testing connectivity to {server_url}...")  # noqa: T201
+    logger.info(f"Testing connectivity to {server_url}...")
     try:
         import requests
 
         response = requests.get(f"{server_url}/api/v1/server_settings")
         if response.status_code == 200:
-            print(f"Successfully connected to {server_url}")  # noqa: T201
+            logger.info(f"Successfully connected to {server_url}")
             try:
                 settings = response.json()
-                print(
+                logger.info(
                     f"Server version: {settings.get('zulip_version', 'unknown')}"
-                )  # noqa: T201
+                )
             except json.JSONDecodeError:
-                print("Received response, but couldn't parse as JSON")  # noqa: T201
+                logger.error("Received response, but couldn't parse as JSON")
         else:
-            print(
-                f"Failed to connect: HTTP status {response.status_code}"
-            )  # noqa: T201
+            logger.error(f"Failed to connect: HTTP status {response.status_code}")
     except Exception as e:
-        print(f"Connection error: {e}")  # noqa: T201
+        logger.error(f"Connection error: {e}")
 
 
 def check_terminal_capabilities() -> None:
     """
     Check for terminal capabilities that might affect Zulip Terminal.
     """
-    print("Checking terminal capabilities...")  # noqa: T201
+    logger.info("Checking terminal capabilities...")
 
     # Check for color support
     colors = os.environ.get("TERM", "unknown")
-    print(f"TERM environment: {colors}")  # noqa: T201
+    logger.info(f"TERM environment: {colors}")
 
     if "COLORTERM" in os.environ:
-        print(f"COLORTERM: {os.environ['COLORTERM']}")  # noqa: T201
+        logger.info(f"COLORTERM: {os.environ['COLORTERM']}")
 
     # Check for Unicode support
-    print("\nTesting Unicode rendering capabilities:")  # noqa: T201
+    logger.info("\nTesting Unicode rendering capabilities:")
     test_chars = [
         ("Basic symbols", "▶ ◀ ✓ ✗"),
         ("Emoji (simple)", "😀 🙂 👍"),
@@ -113,17 +115,17 @@ def check_terminal_capabilities() -> None:
     ]
 
     for name, chars in test_chars:
-        print(f"  {name}: {chars}")  # noqa: T201
+        logger.info(f"  {name}: {chars}")
 
     # Check for urwid compatibility
     try:
         import urwid  # noqa: F401
 
-        print("\nUrwid detected. Running basic urwid test...")  # noqa: T201
+        logger.info("\nUrwid detected. Running basic urwid test...")
         # This doesn't actually run a visual test - just checks if urwid can be imported
-        print("Urwid import successful")  # noqa: T201
+        logger.info("Urwid import successful")
     except ImportError:
-        print("Urwid not found. This may indicate installation issues.")  # noqa: T201
+        logger.warning("Urwid not found. This may indicate installation issues.")
 
 
 def main() -> None:
@@ -162,7 +164,7 @@ def main() -> None:
         cmd = ["zulip-term", "-d"]
         if args.profile:
             cmd.append("--profile")
-        print(f"Running: {' '.join(cmd)}")  # noqa: T201
+        logger.info(f"Running: {' '.join(cmd)}")
         subprocess.run(cmd)
     else:
         parser.print_help()