Skip to content

Commit d4df8f9

Browse files
committed
set-status: Remove the status-suggestion items touch feedback
As Chris mentioned in #1769 description: "Remove the InkWell touch feedback on status-suggestion items. I usually like touch feedback, but the Figma doesn't specify it here, and it's not clear if we'd want it to extend through the device insets or not. Thankfully there's no network request so it should always be immediately clear that a tap was detected (the inputs will change)."
1 parent ab2a091 commit d4df8f9

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

lib/widgets/set_status.dart

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import '../basic.dart';
88
import '../generated/l10n/zulip_localizations.dart';
99
import '../log.dart';
1010
import 'app_bar.dart';
11-
import 'color.dart';
1211
import 'emoji_reaction.dart';
1312
import 'icons.dart';
1413
import 'inset_shadow.dart';
@@ -316,16 +315,9 @@ class StatusSuggestionsListEntry extends StatelessWidget {
316315

317316
@override
318317
Widget build(BuildContext context) {
319-
final designVariables = DesignVariables.of(context);
320-
321-
return InkWell(
318+
return GestureDetector(
319+
behavior: HitTestBehavior.opaque,
322320
onTap: onTap,
323-
splashFactory: NoSplash.splashFactory,
324-
overlayColor: WidgetStateColor.resolveWith(
325-
(states) => states.any((e) => e == WidgetState.pressed)
326-
? designVariables.contextMenuItemBg.withFadedAlpha(0.20)
327-
: Colors.transparent,
328-
),
329321
child: Padding(
330322
padding: EdgeInsets.symmetric(vertical: 7, horizontal: 16),
331323
child: Row(

0 commit comments

Comments
 (0)